-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Fix boolean configuration #11483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix boolean configuration #11483
Conversation
Signed-off-by: Yoofi Quansah <[email protected]>
This reverts commit 7d91e4d.
Signed-off-by: Yoofi Quansah <[email protected]>
Welcome @yquansah! |
Hi @yquansah. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@yquansah thanks for this contribution. /triage accepted |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: longwuyuan, yquansah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.10 |
@Gacko: #11483 failed to apply on top of branch "release-1.10":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* chore: fix booleans to all have quotes around their values Signed-off-by: Yoofi Quansah <[email protected]> * Revert "chore: fix booleans to all have quotes around their values" This reverts commit 7d91e4d. * chore: fix default values for boolean configuration Signed-off-by: Yoofi Quansah <[email protected]> --------- Signed-off-by: Yoofi Quansah <[email protected]>
What this PR does / why we need it:
There is inconsistency with how some boolean values are quoted vs. some are not. This PR addresses that issue and quotes the non-quoted boolean values. Before the markdown table, it states how boolean values need to be quoted because of how
ConfigMap
s only work with strings, so this change accounts for all of that.Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: