Skip to content

Repository: Update owners. #12519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k8s-ci-robot merged 1 commit into from
Dec 21, 2024
Merged

Repository: Update owners. #12519

k8s-ci-robot merged 1 commit into from
Dec 21, 2024

Conversation

@strongjz
Copy link
Member

@strongjz strongjz commented Dec 17, 2024

Remove folks who have no longer contributing to the project.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 17, 2024
@k8s-ci-robot k8s-ci-robot requested review from Gacko and puerco December 17, 2024 16:54
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 17, 2024
@strongjz strongjz removed the request for review from puerco December 17, 2024 16:54
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 17, 2024
@netlify
Copy link

netlify bot commented Dec 17, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit ccf3407
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/67645a2eb5b28300082e704a

@strongjz
Copy link
Member Author

strongjz commented Dec 17, 2024

@tao12345666333 is there a reason you were removed as an admin?

Gacko
Gacko requested changes Dec 17, 2024
View reviewed changes
OWNERS_ALIASES Outdated
Comment on lines 12 to 13

- tao12345666333

Copy link
Member

@Gacko Gacko Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't used anywhere, same for sig-network-leads. I'd rather remove them then.

@tao12345666333
Copy link
Member

tao12345666333 commented Dec 18, 2024

@tao12345666333 is there a reason you were removed as an admin?

@strongjz I guess it might be a mistake in some operation.

1 similar comment
@tao12345666333
Copy link
Member

tao12345666333 commented Dec 18, 2024

@tao12345666333 is there a reason you were removed as an admin?

@strongjz I guess it might be a mistake in some operation.

@Gacko
Copy link
Member

Gacko commented Dec 18, 2024

This admin group here is useless. These files are only being used for owners. If we want @tao12345666333 to become an admin, we need to add him in kubernetes/org. I can do this.

This confusion is the reason I'd like to remove the whole group from the owner aliases, as people might think it's actually used. 🙂

@k8s-ci-robot k8s-ci-robot added area/helm Issues or PRs related to helm charts size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2024
@Gacko Gacko changed the title update owner aliases Repository: Update owner aliases. Dec 18, 2024
@Gacko
Copy link
Member

Gacko commented Dec 18, 2024

/cherry-pick release-1.12

@Gacko
Copy link
Member

Gacko commented Dec 18, 2024

/cherry-pick release-1.11

@k8s-infra-cherrypick-robot
Copy link
Contributor

k8s-infra-cherrypick-robot commented Dec 18, 2024

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link
Contributor

k8s-infra-cherrypick-robot commented Dec 18, 2024

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Gacko
Copy link
Member

Gacko commented Dec 18, 2024

/cherry-pick release-1.10

@k8s-infra-cherrypick-robot
Copy link
Contributor

k8s-infra-cherrypick-robot commented Dec 18, 2024

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Gacko
Copy link
Member

Gacko commented Dec 18, 2024

/lgtm
/hold

@strongjz I only added the hold so you can review the changes I added before merging. So feel free to unhold when ready to merge!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2024
@Gacko
Copy link
Member

Gacko commented Dec 18, 2024

/triage accepted
/kind cleanup
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Dec 18, 2024
tao12345666333
tao12345666333 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Gacko Gacko changed the title Repository: Update owner aliases. Repository: Update owners. Dec 19, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2024
@Gacko
Copy link
Member

Gacko commented Dec 21, 2024

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 21, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, strongjz, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Gacko,strongjz,tao12345666333]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bd3ee3e into kubernetes:main Dec 21, 2024
46 checks passed
@k8s-infra-cherrypick-robot
Copy link
Contributor

k8s-infra-cherrypick-robot commented Dec 21, 2024

@Gacko: new pull request created: #12568

Details

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Dec 21, 2024
Merged
Merged
@k8s-infra-cherrypick-robot
Copy link
Contributor

k8s-infra-cherrypick-robot commented Dec 21, 2024

@Gacko: new pull request created: #12569

Details

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot
Copy link
Contributor

k8s-infra-cherrypick-robot commented Dec 21, 2024

@Gacko: new pull request created: #12570

Details

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 21, 2024
Merged
@strongjz strongjz deleted the clean-owners branch January 8, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gacko Gacko Gacko approved these changes

@tao12345666333 tao12345666333 tao12345666333 approved these changes

Assignees

@Gacko Gacko

@tao12345666333 tao12345666333

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@strongjz @tao12345666333 @Gacko @k8s-infra-cherrypick-robot @k8s-ci-robot