-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Network: Rework IPv6 check. #12905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network: Rework IPv6 check. #12905
Conversation
Welcome @maxgio92! |
Hi @maxgio92. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
33a2795
to
7e6c78c
Compare
The previous check was requiring the test shell builtin to check interface with IPv6 under procfs. The same has been achieved with this commit using go "os" standard library. Furthermore a preliminary check on the kernel-level setting to disable IPv6 is introduced, such that id IPv6 is disabled as kernel feature no further checks on interfaces is done in order to check if IPv6 is enabled. Signed-off-by: Massimiliano Giovagnoli <[email protected]>
7e6c78c
to
bdce9aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/triage accepted
/kind feature
/priority backlog
Basically looks good to me, ping me as soon as you're ready for review.
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
Thank you @Gacko! I've just enabled the test that was commented for IPV6, to be run executed only with the Go build tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 89luca89, Gacko, maxgio92, prometherion The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The previous check was requiring the test shell builtin to check interface with IPv6 under procfs.
The same has been achieved with this commit using go "os" standard library.
Furthermore a preliminary check on the kernel-level setting to disable IPv6 is introduced, such that id IPv6 is disabled as kernel feature no further checks on interfaces is done in order to check if IPv6 is enabled.
Fixes #12903
What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
fixes #12903
How Has This Been Tested?
This
net
test has been enabled under a specific build flagtest_ipv6
.Checklist: