Skip to content

Chart: Add controller.admissionWebhooks.certManager.*.revisionHistoryLimit. #12906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Mar 3, 2025
Merged

Chart: Add controller.admissionWebhooks.certManager.*.revisionHistoryLimit. #12906

merged 18 commits into from
Mar 3, 2025

Conversation

Aransh
Copy link
Contributor

@Aransh Aransh commented Feb 27, 2025

What this PR does / why we need it:

Seeing lots of rotations on the certificate for the webhook. So want to mitigate the problem first by providing a revisionHistoryLimit on the cert according to https://cert-manager.io/docs/reference/api-docs/#cert-manager.io/v1.CertificateSpec

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 27, 2025
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/helm Issues or PRs related to helm charts needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Aransh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 27, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit be1e221
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/67c591c4bac1b00008980553

@Aransh
update README
233711d 
Signed-off-by: Aran Shavit <[email protected]>
Gacko
Gacko requested changes Feb 28, 2025
View reviewed changes
Copy link
Member

@Gacko Gacko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retitle Chart: Add controller.admissionWebhooks.certManager.*.revisionHistoryLimit.
/triage accepted
/kind feature
/priority backlog
/hold

Please also implement at least unit tests in the tests/ directory.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2025
@k8s-ci-robot k8s-ci-robot changed the title feat(chart): add support for revisionHistoryLimit on the cert Chart: Add controller.admissionWebhooks.certManager.*.revisionHistoryLimit. Feb 28, 2025
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Feb 28, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 2, 2025
@Aransh
run helm-docs
86d45cf 
Signed-off-by: Aran Shavit <[email protected]>
@Aransh
Copy link
Contributor Author

Aransh commented Mar 2, 2025

Please also implement at least unit tests in the tests/ directory.

@Gacko Done

@Aransh Aransh requested a review from Gacko March 2, 2025 09:32
Gacko
Gacko requested changes Mar 3, 2025
View reviewed changes
Aransh and others added 8 commits March 3, 2025 11:52
@Aransh @Gacko
Update charts/ingress-nginx/values.yaml
cce6867 
Co-authored-by: Marco Ebert <[email protected]>
@Aransh @Gacko
Update charts/ingress-nginx/templates/admission-webhooks/cert-manager…
5d599e0 
….yaml

Co-authored-by: Marco Ebert <[email protected]>
@Aransh @Gacko
Update charts/ingress-nginx/values.yaml
0ff610c 
Co-authored-by: Marco Ebert <[email protected]>
@Aransh @Gacko
Update charts/ingress-nginx/templates/admission-webhooks/cert-manager…
17e9044 
….yaml

Co-authored-by: Marco Ebert <[email protected]>
@Aransh @Gacko
Update charts/ingress-nginx/tests/admission-webhooks/webhook-certific…
5a63d49 
…ate_test.yaml

Co-authored-by: Marco Ebert <[email protected]>
@Aransh @Gacko
Update charts/ingress-nginx/tests/admission-webhooks/webhook-certific…
d0486e3 
…ate_test.yaml

Co-authored-by: Marco Ebert <[email protected]>
@Aransh @Gacko
Update charts/ingress-nginx/tests/admission-webhooks/webhook-certific…
4aa5f6c 
…ate_test.yaml

Co-authored-by: Marco Ebert <[email protected]>
@Aransh
renamed file
aa2b793 
Signed-off-by: Aran Shavit <[email protected]>
@Aransh Aransh requested a review from Gacko March 3, 2025 09:55
Aransh added 2 commits March 3, 2025 12:04
@Aransh
fix int comparison
5678f20 
Signed-off-by: Aran Shavit <[email protected]>
@Aransh
run helm-docs
5cf6392 
Signed-off-by: Aran Shavit <[email protected]>
Gacko
Gacko requested changes Mar 3, 2025
View reviewed changes
@Aransh Aransh requested a review from Gacko March 3, 2025 11:26
Gacko
Gacko approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@Gacko Gacko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Aransh, Gacko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2025
@Gacko Gacko merged commit f333b0b into kubernetes:main Mar 3, 2025
37 of 38 checks passed
@Gacko
Copy link
Member

Gacko commented Mar 3, 2025

Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gacko Gacko Gacko approved these changes

@tao12345666333 tao12345666333 Awaiting requested review from tao12345666333

Assignees

@Gacko Gacko

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aransh @k8s-ci-robot @Gacko