Skip to content

Go: Fix Mage. #13077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Go: Fix Mage. #13077

merged 1 commit into from
Mar 25, 2025

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Mar 25, 2025

This is something I was confronted with yesterday during putting together the releases. Since we removed the go.work, one could only run Mage from inside the magefiles directory. But in there, the relevant files such as the TAG file are missing.

To be able to execute Mage from the root directory, I removed the go.mod inside the magefiles directory and ran the following script to update the go.mod in the root directory:

clear ; for module in $(dirname **/go.mod | sort --unique)
do
  echo "# ${module}"
  pushd "${module}" &> /dev/null
  for i in {1..3}
  do
    rm -f go.sum
    go get -t -u ./...
    go mod tidy
  done
  popd &> /dev/null
done

/triage accepted
/kind bug
/priority backlog
/cc @strongjz @tao12345666333

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 25, 2025
Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 683a2b2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/67e26c03e79c0e000838a39b

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Gacko,tao12345666333]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tao12345666333
Copy link
Member

/retest

@Gacko
Copy link
Member Author

Gacko commented Mar 25, 2025

AFAIK /retest only affects Prow based tests. GitHub Actions need to be re-triggered by someone with either write access or even admin access, sadly. 🫠

@k8s-ci-robot k8s-ci-robot merged commit 1d7abc1 into kubernetes:main Mar 25, 2025
23 checks passed
@Gacko Gacko deleted the mysuk branch March 26, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants