Skip to content

NGINX: Add NJS. #13324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2025
Merged

NGINX: Add NJS. #13324

merged 2 commits into from
May 6, 2025

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented May 2, 2025 •
edited
Loading

What this PR does / why we need it:

This PR adds NGINX NJS support to the NGINX base image. Credits to @anurag-rajawat!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

How Has This Been Tested?

Building NGINX.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2025
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2025
@netlify Netlify
Copy link

netlify bot commented May 2, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 1bc6ab4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/68150e97884c7f0008b5a564

@Gacko Gacko added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2025
@Gacko
Copy link
Member Author

Gacko commented May 2, 2025 •
edited
Loading

/triage accepted
/kind feature
/priority backlog
/hold

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels May 2, 2025
@Gacko Gacko force-pushed the umwzr branch 3 times, most recently from b8f64d9 to b146f57 Compare May 2, 2025 07:27
@Gacko Gacko added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 2, 2025
strongjz
strongjz reviewed May 2, 2025
View reviewed changes
@Gacko Gacko requested a review from strongjz May 2, 2025 18:23
@Gacko Gacko removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2025
@Gacko
Copy link
Member Author

Gacko commented May 5, 2025

So, with no questions left... shall we merge this? A LGTM would be nice! 🙂

@strongjz
Copy link
Member

strongjz commented May 6, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@strongjz strongjz added this to the release-1.13 milestone May 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 3710e62 into kubernetes:main May 6, 2025
39 checks passed
@Gacko Gacko deleted the umwzr branch May 6, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 Awaiting requested review from tao12345666333

@strongjz strongjz Awaiting requested review from strongjz

Assignees

@strongjz strongjz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
release-1.13
Development

Successfully merging this pull request may close these issues.
5 participants
@Gacko @strongjz @k8s-ci-robot @tao12345666333 @anurag-rajawat