Skip to content

Images: Fix LuaRocks. #13478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Images: Fix LuaRocks. #13478

merged 1 commit into from
Jun 5, 2025

Conversation

Gacko
Copy link
Member

@Gacko Gacko commented Jun 5, 2025

What this PR does / why we need it:

The Lua package repositories recently exceeded kind of a magic limit for LuaRocks and it therefore failed to process the manifest downloaded during package installation.

There already is a fix, but it's still on the main branch and not yet released. This PR makes use of this fix by referencing it by its commit hash.

Additionally I learned, that Alpine seems to come with a BusyBox variant of wget pre-installed, which is not compatible with this more recent version of LuaRocks. I therefore had to explicitly install wget, so it is provided in its GNU version.

Here's an example of the error message:

#10 [6/7] RUN luarocks install busted
#10 1.312 Warning: Failed searching manifest: Failed loading manifest for https://luarocks.org: Error loading file: [string "/root/.cache/luarocks/https___luarocks.org/ma..."]:202836: main function has more than 65536 constants
#10 1.658 Warning: Failed searching manifest: Failed loading manifest for https://raw.githubusercontent.com/rocks-moonscript-org/moonrocks-mirror/master/: Error loading file: [string "/root/.cache/luarocks/https___raw.githubuserc..."]:202836: main function has more than 65536 constants
#10 2.449 Warning: Failed searching manifest: Failed downloading https://luafr.org/luarocks/manifest-5.1 - failed downloading https://luafr.org/luarocks/manifest-5.1

And here is the upstream issue with more details: luarocks/luarocks#1797

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 5, 2025
@k8s-ci-robot k8s-ci-robot requested a review from strongjz June 5, 2025 13:09
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 5, 2025
@k8s-ci-robot k8s-ci-robot added the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jun 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-priority approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 5, 2025
@Gacko
Copy link
Member Author

Gacko commented Jun 5, 2025

/triage accepted
/kind cleanup
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 5, 2025
@Gacko Gacko added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit 39744ba into kubernetes:release-1.11 Jun 5, 2025
16 checks passed
@Gacko Gacko deleted the uzimi branch June 5, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants