-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Images: Update LuaRocks to v3.12.0. #13486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
|
Welcome @bzp2010! |
Hi @bzp2010. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hey hey! First of all thank you very much, it's very kind of you that you're tracking down who is currently using the commit instead of a release of your fix! 🙏 Your proposal basically looks good to me, lemme just do a little change to it, because I'd prefer keeping the Regards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retitle Images: Update LuaRocks to v3.12.0.
/triage accepted
/kind cleanup
/priority backlog
/hold
/cherry-pick release-1.12 |
/cherry-pick release-1.11 |
@Gacko: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Gacko: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
477f5f9
to
a5a88a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/unhold
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bzp2010, Gacko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Gacko: new pull request created: #13487 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Gacko: new pull request created: #13488 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-1.11 |
@Gacko: new pull request created: #13489 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-1.11 |
@Gacko: new pull request created: #13496 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
After encountering issues with LuaRocks on LuaJIT, I collaborated with the LuaRocks maintainers to address the issues through the following pull requests: luarocks/luarocks#1798 and luarocks/luarocks#1799.
The maintainers of LuaRocks have released a new latest version that includes the aforementioned fixes.
This project has implemented a temporary fix for the issue in #13476 by specifying my PR commit ID. As a temporary fix, this is not conducive to long-term maintenance; people may ask why this commit was used, and the reason can only be found through further investigation.
Since the upstream has released a dedicated fix version for this, this PR sets LuaRocks to version
3.12.0
.All modifications are simply the reverse of the version code and SHA256 in #13476.
Types of changes
Which issue/s this PR fixes
No related open issues
How Has This Been Tested?
This modification can be tested by running the workflow.
Checklist: