Chart: Add activeDeadlineSeconds.

[hrdkmshra]

What this PR does / why we need it:

1. added activeDeadlineSeconds : 0 in ingress-nginx/charts/ingress-nginx/values.yaml.
2. used conditional templating to ensure activeDeadlineSeconds is only included in the Job spec when explicitly set greater than 0.
3. added unit-tests to ingress-nginx/charts/ingress-nginx/tests/admission-webhooks/job-patch/job-createSecret_test.yaml & ingress-nginx/charts/ingress-nginx/tests/admission-webhooks/job-patch/job-patchWebhook_test.yaml
4. updated the README.md via helm-docs

#13000

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

fixes #13000

How Has This Been Tested?

1. cd ingress-nginx/charts/ingress-nginx

helm lint . 
==> Linting .

1 chart(s) linted, 0 chart(s) failed

helm template . --debug

bash-5.2# helm unittest -f tests/admission-webhooks/job-patch/job-createSecret_test.yaml .

### Chart [ ingress-nginx ] .

 PASS  Admission Webhooks > Patch Job > Create Secret Job       tests/admission-webhooks/job-patch/job-createSecret_test.yaml

Charts:      1 passed, 1 total
Test Suites: 1 passed, 1 total
Tests:       3 passed, 3 total
Snapshot:    0 passed, 0 total
Time:        33.760399ms

bash-5.2# helm unittest -f tests/admission-webhooks/job-patch/job-patchWebhook_test.yaml .

### Chart [ ingress-nginx ] .

 PASS  Admission Webhooks > Patch Job > Patch Webhook Job       tests/admission-webhooks/job-patch/job-patchWebhook_test.yaml

Charts:      1 passed, 1 total
Test Suites: 1 passed, 1 total
Tests:       3 passed, 3 total
Snapshot:    0 passed, 0 total
Time:        23.67955ms

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

Hi @hrdkmshra. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	a6d0437
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-ingress-nginx/deploys/6847d0aca8802f000879d1d5

[Gacko]

Please do not set this by default and tell your PR "optional". 🙂

I'd suggest only rendering this if the value is set to something greater than 0. Otherwise you're not only adding a new property, but also change existing behavior. IIRC tools like Helm already timeout properly and with your change it might "succeed" even though the job didn't.

Please also update the documentation (helm-docs) and add unit tests in the tests/ directory.

[Gacko]

/triage accepted
/kind feature
/priority backlog
/retitle Chart: Add activeDeadlineSeconds.

[hrdkmshra]

Please do not set this by default and tell your PR "optional". 🙂

Understood :)) ,I've updated the PR with correct wording.

I'd suggest only rendering this if the value is set to something greater than 0.

I have followed the suggested approach. To only render, if greater than 0.

Please also update the documentation (helm-docs) and add unit tests in the tests/ directory.

Thank you for pointing this out, helm lint is something very new to me, that's the only part I struggled with alot (apologies for making to many minute commits and made this PR messy).

[Gacko]

I rebased your branch on top of main. Apart from that: LGTM!

/lgtm

[Gacko]

The linter errors are my bad, gonna fix them for you.

[Gacko]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, hrdkmshra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Gacko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Gacko]

The failing tests are not your fault. We are relying on an external service for resolving hostnames to private IPs and this service sometimes isn't 100% reliable.