-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Closed
Labels
area/build-releasearea/guest-vmGeneral configuration issues with the minikube guest VMGeneral configuration issues with the minikube guest VMlifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.Denotes an issue or PR has remained open with no activity and has become stale.priority/backlogHigher priority than priority/awaiting-more-evidence.Higher priority than priority/awaiting-more-evidence.
Description
Building the ISO fails, since the upstream git archive randomly changes checksum.
This is due to including vendor/k8s.io/client-go/pkg/version/.gitattributes
base.go export-subst
The substitution will corrupt the git archive, by filling the git info with wrong information.
58,59c58,59
< gitVersion string = "v0.0.0-master+$Format:%h$"
< gitCommit string = "$Format:%H$" // sha1 from git, output of $(git rev-parse HEAD)
---
> gitVersion string = "v0.0.0-master+1e5ef943eb"
> gitCommit string = "1e5ef943eb76627a6d3b6de8cd1ef6537f393a71" // sha1 from git, output of $(git rev-parse HEAD)It was intended to record the kubernetes version, but here has a random short rev of containerd.
Problems started with containerd 1.5.x, that started including k8s.io/client-go (unlike 1.4.x)
Metadata
Metadata
Assignees
Labels
area/build-releasearea/guest-vmGeneral configuration issues with the minikube guest VMGeneral configuration issues with the minikube guest VMlifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.Denotes an issue or PR has remained open with no activity and has become stale.priority/backlogHigher priority than priority/awaiting-more-evidence.Higher priority than priority/awaiting-more-evidence.