Broken CI job: apidiff

[MadhavJivrajani]

The apidiff job is broken since the merge of #243

I don't think its anything to do with the PR itself, but more to do with how apidiff handles things.
I've filed an issue for this with a potential root cause: golang/go#60911

One of 2 can be done here:

• We wait for the release branches to be bumped to go1.20 (which I think is in progress Dependency update - Golang 1.20.0 release#2815 (comment)) and then bump utils to go1.20 and then update sets to use comparable or apidiff to be fixed, whatever happens first.
• Revert add generic sets to utils #243 till we bump to go1.20 or apidiff gets a fix that we can consume (whichever happens first).

IMO we should revert for now to ensure the CI is in good shape for when we need to fix something here to mitigate a test flake/failure in something like k/k.

Reverting isn't an option since we've already merged the API and apidiff will fail on a package level (ref).

/cc @logicalhan
/cc @cpanato (in case you have an estimate yet on the go1.20 bumps of release branches)

[MadhavJivrajani]

There is a fix open for apidiff: https://go-review.googlesource.com/c/exp/+/505276
On installing apidiff with this patch, it seems to fix the problem 🎉

❯ make verify-apidiff
GO111MODULE=on ./hack/verify-apidiff.sh -r master
Inspecting API of master...
Comparing with master...
Ignoring internal package k8s.io/utils/internal/third_party/forked/golang/golang-lru
Ignoring internal package k8s.io/utils/internal/third_party/forked/golang/net
❯ echo $?
0

[dims]

thanks for chasing this @MadhavJivrajani

[MadhavJivrajani]

golang/go#60911 is resolved now 🎉

Created kubernetes/test-infra#30048
Once merged, we can start retriggering the workflows here.

[MadhavJivrajani]

/close
Job is back on its feet.

[k8s-ci-robot]

@MadhavJivrajani: Closing this issue.

In response to this:

/close
Job is back on its feet.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.