Skip to content

Add csi nodeexpandsecret blog article #32450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add csi nodeexpandsecret blog article #32450

wants to merge 1 commit into from

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Mar 23, 2022 •
edited
Loading

@humblec
Copy link
Contributor Author

humblec commented Mar 23, 2022

Cc @xing-yang

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Mar 23, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 23, 2022
@netlify
Copy link

netlify bot commented Mar 23, 2022 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit fe41553
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/624be4d46cbf1200089183f3

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign sftim after the PR has been reviewed.
You can assign the PR to them by writing /assign @sftim in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Mar 23, 2022
@k8s-ci-robot k8s-ci-robot requested a review from sftim March 23, 2022 16:38
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Mar 23, 2022
sftim
sftim reviewed Mar 23, 2022
View reviewed changes
content/en/blog/_posts/2022-04-19-csi-nodeexpandsecret.md
@@ -0,0 +1,8 @@
---
layout: blog
title: "Kubernetes 1.24: Use secrets while expanding csi volumes on Node"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

early nit:

Suggested change
title: "Kubernetes 1.24: Use secrets while expanding csi volumes on Node"
title: "Kubernetes 1.24: Use Secrets While Expanding CSI Volumes On Nodes"

Maybe there is a better title? I might suggest a new one once I've seen what the article is introducing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim sure, I was also in a dilemma about the subject, so inputs are welcome! 👍

@humblec humblec force-pushed the dev-1.24-blog-nodeExpandSecret branch from 323d3e8 to d5ea25c Compare March 30, 2022 03:48
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 30, 2022
@humblec humblec force-pushed the dev-1.24-blog-nodeExpandSecret branch from d5ea25c to c86e883 Compare March 30, 2022 04:19
@humblec humblec requested a review from sftim March 30, 2022 04:19
@sftim
Copy link
Contributor

sftim commented Mar 30, 2022

@humblec if this is ready for review, please edit the PR title to remove the [WIP] prefix

@humblec humblec changed the title [WIP]: add csi nodeexpandsecret blog article Add csi nodeexpandsecret blog article Mar 30, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 30, 2022
@humblec
Copy link
Contributor Author

humblec commented Mar 30, 2022

@humblec if this is ready for review, please edit the PR title to remove the [WIP] prefix

The feature is at last stage of review, thats why I kept the WIP in the title, however if that does not matter, this is good for review @sftim . I have removed the WIP from the title 👍

sftim
sftim suggested changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks.

Overall, I think this will work better if you make it a less technical announcement that links to docs about setting and using these secrets.
What's the URL of the documentation change that we made for this enhancement? I'd like to read that for context.

@humblec humblec force-pushed the dev-1.24-blog-nodeExpandSecret branch 2 times, most recently from 32f628f to c36341a Compare April 5, 2022 06:41
@humblec humblec force-pushed the dev-1.24-blog-nodeExpandSecret branch from c36341a to fe41553 Compare April 5, 2022 06:42
@humblec
Copy link
Contributor Author

humblec commented Apr 5, 2022

Hi, thanks.

Overall, I think this will work better if you make it a less technical announcement that links to docs about setting and using these secrets. What's the URL of the documentation change that we made for this enhancement? I'd like to read that for context.

#32298 covers doc part of it. Thanks @sftim

@humblec humblec requested a review from sftim April 5, 2022 06:43
@humblec humblec mentioned this pull request Apr 5, 2022
Closed
@xing-yang
Copy link
Contributor

@sftim This is moved to 1.25.

@sftim
Copy link
Contributor

sftim commented Apr 7, 2022

@humblec I recommend that you keep this text ready for a future branch, but close this PR.

@sftim
Copy link
Contributor

sftim commented Apr 10, 2022

/close

@k8s-ci-robot
Copy link
Contributor

@sftim: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@humblec
Copy link
Contributor Author

humblec commented Apr 11, 2022

@humblec I recommend that you keep this text ready for a future branch, but close this PR.

Sure, and thanks for all your review comments ! Will continue or take this version to next attempt. Thanks @sftim

@mehabhalodiya
Copy link
Contributor

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the 1.24 milestone Apr 28, 2022
humblec added a commit to humblec/kubernetes.github.io that referenced this pull request Jul 25, 2022
@humblec
csi: add nodeExpandSecret KEP details
11346ca 
Ref#
KEP: kubernetes/enhancements#3173
Implementation: kubernetes/kubernetes#105963
Blog: kubernetes#32450

Signed-off-by: Humble Chirammal <[email protected]>
humblec added a commit to humblec/kubernetes.github.io that referenced this pull request Jul 25, 2022
@humblec
si: add nodeExpandSecret KEP details
7ab3fd5 
Ref#
KEP: kubernetes/enhancements#3173
Implementation: kubernetes/kubernetes#105963
Blog: kubernetes#32450

Signed-off-by: Humble Chirammal <[email protected]>
@humblec humblec mentioned this pull request Jul 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@sftim sftim Awaiting requested review from sftim

Assignees
No one assigned
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@humblec @k8s-ci-robot @sftim @xing-yang @mehabhalodiya