Skip to content

KEP-4633: Add documentation for Configurable Endpoints for Anonymous Auth. #46988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

vinayakankugoyal
Copy link
Contributor

@vinayakankugoyal vinayakankugoyal commented Jun 26, 2024

Add documentation for Alpha phase of kubernetes/enhancements#4633.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jun 26, 2024
@k8s-ci-robot k8s-ci-robot requested review from deads2k and lavalamp June 26, 2024 21:33
Copy link

netlify bot commented Jun 26, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 4b2940e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/667fae51f7c50300087043eb
😎 Deploy Preview https://deploy-preview-46988--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added area/localization General issues or PRs related to localization language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 26, 2024
@vinayakankugoyal vinayakankugoyal changed the base branch from main to dev-1.31 June 26, 2024 22:10
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 26, 2024
Copy link

netlify bot commented Jun 26, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 4b2940e
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/667fae514ecd5300080e3b14

@vinayakankugoyal vinayakankugoyal changed the title KEP-4633: Add documentation for Configurable Endpoints for Anonymous … KEP-4633: Add documentation for Configurable Endpoints for Anonymous Auth. Jun 26, 2024
@dipesh-rawat
Copy link
Member

/remove-language zh
/remove-area localization

@k8s-ci-robot k8s-ci-robot removed language/zh Issues or PRs related to Chinese language area/localization General issues or PRs related to localization labels Jun 27, 2024
@dipesh-rawat
Copy link
Member

/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Jun 27, 2024
@MaryamTavakkoli
Copy link
Contributor

Hello @vinayakankugoyal 👋 Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday July 16th 2024 18:00 PST. Thank you!

@vinayakankugoyal vinayakankugoyal marked this pull request as ready for review July 8, 2024 22:36
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2024
@k8s-ci-robot k8s-ci-robot requested a review from tengqm July 8, 2024 22:37
@vinayakankugoyal
Copy link
Contributor Author

/cc @liggitt

@k8s-ci-robot k8s-ci-robot requested a review from liggitt July 16, 2024 00:39
@liggitt
Copy link
Member

liggitt commented Jul 17, 2024

technical content lgtm

Copy link
Contributor

@Princesso Princesso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 658ed590f23ea079e37e6aa8bae71fffd44dc394

@MaryamTavakkoli
Copy link
Contributor

Hello @vinayakankugoyal 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday July 30th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you!

@vinayakankugoyal
Copy link
Contributor Author

@MaryamTavakkoli - Thank you so much for the heads up!

@Princesso - from sig-docs-en-owners - @liggitt has already lgtm'd from a technical review perspective. Would you be ok with approving this PR? I appreciate your review and lgtm!

@tengqm
Copy link
Contributor

tengqm commented Jul 24, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit a77fcc7 into kubernetes:dev-1.31 Jul 24, 2024
6 checks passed
@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants