Website updates for WinDSR / WinOverlay v1.33 beta #49904
Conversation
|
@marosset: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
language/en
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
✅ Pull request preview available for checking
To edit notification comments on pull requests, go to your Netlify site configuration. |
marosset
force-pushed
the
5100-winsdr-winoverlay-beta-website-updates
branch
from
209ac63 to
1e69f16
Compare
k8s-ci-robot
added
size/S
marosset
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
content/en/docs/concepts/services-networking/windows-networking.md
Outdated
Show resolved
Hide resolved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: ed08ccc245728b7ae8d041f137f4f03b8a242f2e
|
content/en/docs/concepts/services-networking/windows-networking.md
Outdated
Show resolved
Hide resolved
content/en/docs/concepts/services-networking/windows-networking.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This is generated documentation. It should be generated based on upstream code and changed in its own commit, away from other docs updates. We do that generated docs change anyway as part of the release.
BTW, if “Retrun“ is a typo there, you might want to fix it.
There was a problem hiding this comment.
oh, i didn't know this is generated.
That flag has existed for a few releases but I didn't see it listed here (maybe the because it is a windows only flag)?
Yes, that is a type, i will fix :(
There was a problem hiding this comment.
We try to make it as obvious as we can but if you're looking at the Markdown source it may not jump out at you. Anyway, yes, is.
k8s-ci-robot
removed
the
lgtm
There was a problem hiding this comment.
I'd omit the changes to this file (because it's auto-generated). OK to commit the output of the generator if you have run it; separate commit though please.
Signed-off-by: Mark Rossetti <[email protected]> Co-authored-by: Tim Bannister <[email protected]>
marosset
force-pushed
the
5100-winsdr-winoverlay-beta-website-updates
branch
from
036a161 to
3434a09
Compare
|
Hello @marosset 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Hi @jsturtevant Docs team here! |
|
Giving an lgtm as we're near to the Docs Freeze deadline. It was lgtm-ed before however it was removed because of a commit which addressed the Docs review suggestions. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 18e1b695518542ee5d9a9289b26c86b588d3c244
|
|
/lgtm |
Description
Add documentation for WinDSR / WinOverlay kube-proxy functionality.
Issue
kubernetes/enhancements#5100
Closes: #
/sig windows network
/milestone v1.33