-
Notifications
You must be signed in to change notification settings - Fork 15k
KEP-4633: Graduate to Stable. #50838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend also updating https://kubernetes.io/docs/concepts/security/controlling-access/
That authentication section in https://kubernetes.io/docs/concepts/security/controlling-access/ looks too high level to add the details of this feature. Plus it already links to https://kubernetes.io/docs/reference/access-authn-authz/authentication/ where we cover Anonymous Requests in detail. |
Thanks for updating the sample as well! /lgtm |
LGTM label has been added. Git tree hash: b95ca8db99f59b9ac663a22d0667d4642c287c34
|
/sig auth |
@kubernetes/sig-auth-pr-reviews : PTAL for tech accuracy. |
True, but: don't add the detail. Do mention that the mechanism exists. I didn't think this sentence from the existing doc is strictly true:
We should correct it. |
/reopen |
code PR: kubernetes/kubernetes#131654 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Update the feature-gate in the docs to stable. I took a look at the docs and AFAICT they don't need an update.
Issue
xref: #kubernetes/enhancements#4633