Skip to content

KEP-4633: Graduate to Stable. #50838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

vinayakankugoyal
Copy link
Contributor

@vinayakankugoyal vinayakankugoyal commented May 7, 2025

Description

Update the feature-gate in the docs to stable. I took a look at the docs and AFAICT they don't need an update.

Issue

xref: #kubernetes/enhancements#4633

@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone May 7, 2025
Copy link

netlify bot commented May 7, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 4b0b534
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/684b00b7bcf91900084e405d

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels May 7, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 7, 2025
@vinayakankugoyal vinayakankugoyal marked this pull request as draft May 7, 2025 21:55
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2025
Copy link

netlify bot commented May 7, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 4b0b534
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/684b00b7a9597d0008425309
😎 Deploy Preview https://deploy-preview-50838--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinayakankugoyal
Copy link
Contributor Author

I recommend also updating https://kubernetes.io/docs/concepts/security/controlling-access/

That authentication section in https://kubernetes.io/docs/concepts/security/controlling-access/ looks too high level to add the details of this feature. Plus it already links to https://kubernetes.io/docs/reference/access-authn-authz/authentication/ where we cover Anonymous Requests in detail.

@vinayakankugoyal vinayakankugoyal marked this pull request as ready for review June 12, 2025 15:08
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2025
@shannonxtreme
Copy link
Contributor

Thanks for updating the sample as well!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 12, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b95ca8db99f59b9ac663a22d0667d4642c287c34

@divya-mohan0209
Copy link
Contributor

/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Jun 15, 2025
@divya-mohan0209
Copy link
Contributor

@kubernetes/sig-auth-pr-reviews : PTAL for tech accuracy.

@enj enj added this to SIG Auth Jun 15, 2025
@enj enj moved this to Needs Triage in SIG Auth Jun 15, 2025
@aramase aramase moved this from Needs Triage to In Review in SIG Auth Jun 16, 2025
@lmktfy
Copy link
Contributor

lmktfy commented Jul 1, 2025

I recommend also updating https://kubernetes.io/docs/concepts/security/controlling-access/

That authentication section in https://kubernetes.io/docs/concepts/security/controlling-access/ looks too high level to add the details of this feature.

True, but: don't add the detail. Do mention that the mechanism exists.

I didn't think this sentence from the existing doc is strictly true:

If the request cannot be authenticated, it is rejected with HTTP status code 401.

We should correct it.

@lmktfy lmktfy closed this Jul 1, 2025
@github-project-automation github-project-automation bot moved this from In Review to Closed / Done in SIG Auth Jul 1, 2025
@lmktfy
Copy link
Contributor

lmktfy commented Jul 1, 2025

/reopen
Misclick!

@lmktfy lmktfy reopened this Jul 1, 2025
@github-project-automation github-project-automation bot moved this from Closed / Done to Needs Triage in SIG Auth Jul 1, 2025
@reylejano
Copy link
Member

code PR: kubernetes/kubernetes#131654
enhancement tracked for 1.34
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit e7b2e4a into kubernetes:dev-1.34 Jul 14, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Closed / Done in SIG Auth Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Closed / Done
Development

Successfully merging this pull request may close these issues.

6 participants