Skip to content

Update capkk crds#2426

Merged
ks-ci-bot merged 1 commit into
kubesphere:feature-gitopsfrom
dbbDylan:feature-capkk-crds
Oct 10, 2024
Merged

Update capkk crds#2426
ks-ci-bot merged 1 commit into
kubesphere:feature-gitopsfrom
dbbDylan:feature-capkk-crds

Conversation

@dbbDylan

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind design

What this PR does / why we need it:

Patch for PR#2409

Which issue(s) this PR fixes:

Fixes #

  • Adjust some comments and import alias
  • Replace inventory group name spec defination with crd annotation
  • Add deal with secrets annotation for init and refresh secrets created by kubeadm components

Special notes for reviewers:

Does this PR introduced a user-facing change?

- Adjust some comments and import alias
- Replace inventory group name spec defination with crd annotation
- Add deal with secrets annotation for init and refresh secrets created by kubeadm components

Additional documentation, usage docs, etc.:


@kubesphere-prow kubesphere-prow Bot added release-note kind/design Categorizes issue or PR as related to design. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 10, 2024
@sonarqubecloud

Copy link
Copy Markdown

@redscholar redscholar added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Oct 10, 2024
@kubesphere-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: dbbDylan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot merged commit 87deeac into kubesphere:feature-gitops Oct 10, 2024
@dbbDylan dbbDylan mentioned this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/design Categorizes issue or PR as related to design. lgtm Indicates that a PR is ready to be merged. release-note size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants