Skip to content

Fix quality-check CI working directory path#2111

Merged
clubanderson merged 1 commit into
masterfrom
fix/quality-check-working-dir
Apr 29, 2026
Merged

Fix quality-check CI working directory path#2111
clubanderson merged 1 commit into
masterfrom
fix/quality-check-working-dir

Conversation

@clubanderson
Copy link
Copy Markdown
Contributor

Fixes quality-check CI ENOENT failures affecting PRs #2105, #2106, #2107, #2108

Problem

The kb-quality-enforcement.yml workflow was running the quality checker from the scripts/ directory while the script tried to read files using repo-root-relative paths like fixes/cncf-generated/..., causing ENOENT errors.

Solution

Changed the workflow to:

  1. Run the script from the repo root: node scripts/test-kb-quality-ci.mjs
  2. Access the changed files list from the repo root: changed_files.txt

This ensures file paths resolve correctly when the script reads them.

Signed-off-by: Andy Anderson <clubanderson@gmail.com>
@kubestellar-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2026
@clubanderson clubanderson merged commit 1e12291 into master Apr 29, 2026
2 of 3 checks passed
@kubestellar-prow kubestellar-prow Bot deleted the fix/quality-check-working-dir branch April 29, 2026 07:36
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant