Bump sigs.k8s.io/controller-runtime to 16.3 #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perator Signed-off-by: Alex Kalenyuk <[email protected]>
Signed-off-by: Alex Kalenyuk <[email protected]>
Signed-off-by: Alex Kalenyuk <[email protected]>
This reverts commit 69b30de. Signed-off-by: Alex Kalenyuk <[email protected]>
kubevirt-bot
added
dco-signoff: yes
Barakmor1
reviewed
Nov 5, 2023
Comment on lines
125
to
128
| // src := args.mockController.WatchCalls[0].Src | ||
| // // kind, ok := src.(*source.Kind) | ||
| // // Expect(ok).To(BeTrue()) | ||
| // // Expect(kind.Type).To(BeAssignableToTypeOf(&testcr.Config{})) |
There was a problem hiding this comment.
yeah should find a way to keep testing this
Barakmor1
reviewed
Nov 5, 2023
| @@ -609,10 +608,12 @@ var _ = Describe("Reconciler", func() { | |||
| //Modify CRD to be of previousVersion | |||
| _ = args.reconciler.CrSetVersion(args.config, prevVersion) | |||
| //mark CR for deletion | |||
| args.config.SetDeletionTimestamp(&metav1.Time{Time: time.Now()}) | |||
| // args.config.SetDeletionTimestamp(&metav1.Time{Time: time.Now()}) | |||
Barakmor1
reviewed
Nov 5, 2023
Comment on lines
736
to
737
| getCfg := func() cache.Cache { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
nit:
getCache := func() cache.Cache {
return nil
}
Barakmor1
reviewed
Nov 5, 2023
Comment on lines
+97
to
+101
| Cache: cache.Options{ | ||
| DefaultNamespaces: map[string]cache.Config{ | ||
| namespace: {}, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
wdym? this is needed to keep the behavior the same as before (Namespace: namespace)
pkg/sdk/reconciler/reconciler.go
Outdated
| @@ -566,7 +567,7 @@ func (r *Reconciler) WatchResourceTypes(resources ...client.Object) error { | |||
| predicates := []predicate.Predicate{sdk.NewIgnoreLeaderElectionPredicate()} | |||
|
|
|||
| if err := r.controller.Watch(source.Kind(r.getCache(), resource), eventHandler, predicates...); err != nil { | |||
| if meta.IsNoMatchError(err) { | |||
| if meta.IsNoMatchError(err) || strings.Contains(err.Error(), "failed to find API group") { | |||
There was a problem hiding this comment.
I would love if we could not do this :( kubernetes-sigs/controller-runtime#2425 (comment)
|
I think it looks great overall, but I left some comments, mostly nits. |
|
@mhenriks can you please take a look? |
Signed-off-by: Alex Kalenyuk <[email protected]>
Signed-off-by: Alex Kalenyuk <[email protected]>
Signed-off-by: Alex Kalenyuk <[email protected]>
Signed-off-by: Alex Kalenyuk <[email protected]>
akalenyu
force-pushed
the
bump-ctrl-runtime-golang
branch
from
5db2a80 to
2b7aebd
Compare
|
@Barakmor1 @vladikr @mhenriks PTAL 🙏 |
|
/release-note-none |
kubevirt-bot
added
release-note-none
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akalenyu, mhenriks The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits are a mess. Will try to restructure