Upgrade html5ever to a TendrilSink based API. #19
Conversation
| @@ -13,21 +13,18 @@ doctest = false | |||
| [features] | |||
| unstable = [ | |||
| "string_cache/unstable", | |||
| "tendril/unstable", | |||
| "rc/unstable", | |||
There was a problem hiding this comment.
It seems "rc/unstable" can be replaced with stabilized Weak element. Perhaps in another PR?
mbrubeck did it for me in Ygg01/xml5ever/pull/12
There was a problem hiding this comment.
Kuchiki needs Rc::strong_count or Rc::would_unwrap, and both are still unstable.
(It could do without them by removing impl Drop for NodeRef, but there would be a risk of stack overflow when dropping deep trees.)
SimonSapin
force-pushed
the
tendrilsink
branch
from
3c8f060 to
d3c856c
Compare
| /// ``` | ||
| pub mod traits { | ||
| pub use iter::{NodeIterator, ElementIterator}; | ||
| pub use html5ever::tendril::TendrilSink; |
There was a problem hiding this comment.
I'm curious why html5ever::tendril::TendrilSink instead of tendril::TendrilSink?
There was a problem hiding this comment.
I’ve made html5ever re-export the tendril crates, so that users like kuchiki don’t need to depend on it themselves. That way, when html5ever upgrades to a semver-incompatible version of tendril, kuchiki will automatically use the same version. Previously, the version numbers of both dependencies had to be kept in sync.
|
Alright, thanks for your comments! |
Upgrade html5ever to a TendrilSink based API.
Waiting on servo/html5ever#188.