Fix type hinting #5
Conversation
|
The test failures here will be fixed once #7 is merged and I've rebased this on top of that PR. |
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 39 45 +6
=========================================
+ Hits 39 45 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Right, so the tests should now pass, because the mypy typechecks are skipped on anything other than 3.10. That's because mypy refuses to acknowledge the backported ParamSpec object for now on anything other than 3.10; I think python/mypy#12011 may be related there. This is a mypy bug, so I'm not taking the hints out again. :-) |
|
Bah, humbug. I'll have to fix the PR push. I was trying to do this via GitHub codespaces on a mobile phone as I am travelling. |
- Use a `ParamSpec` to capture the wrapped function arguments and a separate `TypeVar` for the return type, so that the annotation can accurately wrap just the return value in a `Coroutine` annotation. - Add explicit type hints for functions that use @overload (which are not compatible with ParamSpec). - Add typing-extensions as a dependency (used for ParamSpec on older Python versions) - Add a few simple tests to verify that type hints now are producing correct output.
This PR fixes the type hinting issue #4.
ParamSpecto capture the wrapped function arguments and aseparate
TypeVarfor the return type, so that the annotation canaccurately wrap just the return value in a
Coroutineannotation.are not compatible with ParamSpec).
Python versions)
correct output.
Note that I switched to using
Coroutine[Any, Any, ...]here, it's the moreaccurate type hint.