Method brancher#539
Closed
lekcyjna123 wants to merge 1 commit intokuznia-rdzeni:masterfrom
Closed
Conversation
tilk
reviewed
Dec 18, 2023
| from amaranth import * | ||
|
|
||
|
|
||
| class MethodMock(Elaboratable): |
Member
There was a problem hiding this comment.
This functionality should be moved to another PR, and all method mocks should be updated to use this.
tilk
added
enhancement
Member
|
After merging #551, this is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested by @piotro888 here is the port of
MethodBrancherfrom #395. I had to write a test for the Brancher, so I have decided to port alsoMethodMock, which simplify syntax. Instead of creating low level Adapter and TestbenchIO after that (and a long chain of accessors to get a real method), we can create a MethodMock which presents high level abstraction.