Checkpointing part 2: final integration#846
Draft
awariac wants to merge 18 commits intokuznia-rdzeni:masterfrom
Draft
Checkpointing part 2: final integration#846awariac wants to merge 18 commits intokuznia-rdzeni:masterfrom
awariac wants to merge 18 commits intokuznia-rdzeni:masterfrom
Conversation
awariac
added
enhancement
awariac
added
benchmark
Benchmarks summaryPerformance benchmarks
You can view all the metrics here. Synthesis benchmarks (basic)
Synthesis benchmarks (full)
|
Member
Author
|
yoooo |
Member
|
Nice improvement! |
Member
Author
yeah, it is, but I expected it to be bigger (hope that's not a wishful thinking). Did you have any expectations of it? |
Member
Also hoped for a bigger difference, but it looks like there are other factors at play. A few of the most obvious for me are:
It's hard to decide the importance of these factors on the final performance. There is probably no single biggest reason, I'm starting to believe that OoO performance is complex and comes from a combination of many factors. |
Member
Author
and it doesn't boot, so more obscure bugs awaiting :/ |
Member
Author
|
#451 would be useful to find some manageable test cases |
Member
|
Given that benchmarks and other full core tests work fine, most probably the issue is related to M-mode and interrupt handling. Indeed RISCV-DV claims to cover this. |
Benchmarks summaryPerformance benchmarks
You can view all the metrics here. Synthesis benchmarks (basic)
Synthesis benchmarks (full)
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Member
Author
|
finally made a merge with superscalarity, new frontend and other changes. |
awariac
force-pushed
the
piotro/checkpointing-integration
branch
from
b1c7a58 to
be81f6d
Compare
Benchmarks summaryPerformance benchmarks
You can view all the metrics here. Synthesis benchmarks (basic)
Synthesis benchmarks (full)
|
Benchmarks summaryPerformance benchmarks
You can view all the metrics here. Synthesis benchmarks (basic)
Synthesis benchmarks (full)
|
Benchmarks summaryPerformance benchmarks
You can view all the metrics here. Synthesis benchmarks (basic)
Synthesis benchmarks (full)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkpointing is finally here!!! 🎉 (it took a bit of work and debug)
Integrates rollback-on-branch-misprediction flow and use of instruction tags into the core.
Async interrupts and other exceptions are still handled by flushing the old way.
TODO:
fix other unit tests, verify linux boot, verify benchmarks