Circular allocator#151
Merged
Merged
Conversation
Member
Would be helpful to add extra option to enable logging of each allocation/deallocation, as similar mechanism is used e.g. in Coreblocks CRAT. |
Member
Author
|
I think that it's probably better not to include logging here. Logging messages are nicer when more domain-specific information is available, and it always can be added at the use site. I'm experimenting with the docstring format for methods. I think that it's better to use shapes rather than types after the colons, as this is the information you actually need when interfacing with a method. |
qbojj
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes a FIFO-like allocation system is needed without an actual FIFO. This PR factors out the allocator of
BasicFifoand extends it with multi-allocation.TODO: