Skip to content

Fix deleting buffer that doesn't belong to us - #739

Merged
stmatengss merged 2 commits into
kvcache-ai:mainfrom
SzymonOzog:main
Aug 13, 2025
Merged

stmatengss merged 2 commits into
kvcache-ai:mainfrom
SzymonOzog:main

Conversation

@SzymonOzog

Copy link
Copy Markdown
Contributor

Currently when using CUDA with TCP it assumes that we allocated a new buffer in line 152, it's not always the case and we can free memory that doesn't belong to us causing a segfault later

@stmatengss

Copy link
Copy Markdown
Collaborator

Currently when using CUDA with TCP it assumes that we allocated a new buffer in line 152, it's not always the case and we can free memory that doesn't belong to us causing a segfault later

That's correct. Thank you for the reminder. I believe this is the root cause of issue sgl-project/sglang#7211 (comment).

@stmatengss
stmatengss merged commit bdc7ffb into kvcache-ai:main Aug 13, 2025
wanyue-wy pushed a commit to wanyue-wy/Mooncake that referenced this pull request Dec 14, 2025
* Fix deleting buffer that doesn't belong to us

* Linting
JasonZhang517 pushed a commit to JasonZhang517/Mooncake that referenced this pull request Feb 9, 2026
* Fix deleting buffer that doesn't belong to us

* Linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants