Skip to content

Commit 562f73e

Browse files
Merge pull request #3 from kwameopareasiedu/remove-validate-on-reset
Remove validate on reset
2 parents 1a66fac + 891f05e commit 562f73e

File tree

6 files changed

+332
-330
lines changed

6 files changed

+332
-330
lines changed

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,3 +233,8 @@ form.handleSubmit((values: T) => void): (values: T) => void
233233
## Contributors
234234

235235
- [Kwame Opare Asiedu](https://github.com/kwameopareasiedu)
236+
237+
## Changelog
238+
239+
- 1.0.2 (Current)
240+
- Disabled call to `form.validateField` on `form.reset` to avoid errors on form reset

dist/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example/src/app.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export default function App() {
99
const form = new Form({
1010
initialValues: {
1111
input: "",
12-
range: 50,
12+
range: 30,
1313
select: "",
1414
radio: "",
1515
checkbox: false

package.json

Lines changed: 19 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,17 @@
11
{
22
"name": "vanjs-form",
3-
"version": "1.0.1",
3+
"version": "1.0.2",
44
"description": "Fully typed form state management library (with validation) for VanJS",
55
"repository": "https://github.com/kwameopareasiedu/vanjs-form",
66
"homepage": "https://github.com/kwameopareasiedu/vanjs-form",
7-
"keywords": ["vanjs", "form", "validation"],
8-
"maintainers": ["Kwame Opare Asiedu"],
7+
"keywords": [
8+
"vanjs",
9+
"form",
10+
"validation"
11+
],
12+
"maintainers": [
13+
"Kwame Opare Asiedu"
14+
],
915
"main": "dist/index.js",
1016
"types": "dist/index.d.ts",
1117
"author": "Kwame Opare Asiedu",
@@ -18,18 +24,18 @@
1824
},
1925
"devDependencies": {
2026
"@rollup/plugin-terser": "^0.4.4",
21-
"@rollup/plugin-typescript": "^11.1.5",
22-
"@typescript-eslint/eslint-plugin": "^6.16.0",
23-
"@typescript-eslint/parser": "^6.16.0",
24-
"eslint": "^8.56.0",
25-
"prettier": "3.1.1",
26-
"rollup": "^4.9.1",
27-
"tslib": "^2.6.2"
27+
"@rollup/plugin-typescript": "^11.1.6",
28+
"@typescript-eslint/eslint-plugin": "^7.12.0",
29+
"@typescript-eslint/parser": "^7.12.0",
30+
"eslint": "8.57.0",
31+
"prettier": "3.3.1",
32+
"rollup": "^4.18.0",
33+
"tslib": "^2.6.3"
2834
},
2935
"dependencies": {
30-
"typescript": "^5.3.3",
31-
"vanjs-core": "^1.2.7",
32-
"yup": "^1.3.3"
36+
"typescript": "^5.4.5",
37+
"vanjs-core": "^1.5.0",
38+
"yup": "^1.4.0"
3339
},
3440
"peerDependencies": {
3541
"vanjs-core": "^1.2.7",

src/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ export class Form<T extends Record<string, unknown>> {
142142
field.touched.val = false;
143143
field.error.val = "";
144144

145-
if (this.validationMode === "oninput") this.validateField(name);
145+
// if (this.validationMode === "oninput") this.validateField(name);
146146
}
147147
} else {
148148
for (const key in this.fields) {
@@ -151,7 +151,7 @@ export class Form<T extends Record<string, unknown>> {
151151
field.touched.val = false;
152152
field.error.val = "";
153153

154-
if (this.validationMode === "oninput") this.validateField(key);
154+
// if (this.validationMode === "oninput") this.validateField(key);
155155
}
156156
}
157157
}

0 commit comments

Comments
 (0)