Support only stripping outputs larger than a given size#135
Merged
Conversation
kynan
requested changes
Apr 11, 2021
kynan
left a comment
Owner
There was a problem hiding this comment.
Thanks for your contribution! This is looking pretty good. Some suggested simplifications.
Please rebase and add a test as well!
…fo in README Co-authored-by: Florian Rathgeber <florian.rathgeber@gmail.com>
Contributor
Author
|
@kynan Great, I have added your suggestions. Let me know if there is anything else! |
kynan
approved these changes
May 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to be able to strip embedded images and videos from a notebook while leaving the smaller text output (similar to #58). This PR adds a
--max-sizeoption which removes output larger thanmax-sizebytes.This easily delineates larger binary outputs from smaller textual ones.
I did not want to just filter on keys (an alternative) because a matplotlib animation video may be embedded in a
text/htmlkey, but I don't want to remove everytext/htmlkey. I'm also not sure if embedded images are alwaysimage/pngin all kernels and plotting backends.I've run some ad-hoc benchmarks and computing the size of the outputs in negligible to the overall run time when enabled (~2%-4%).
Thanks!