Skip to content

Conversation

@kyranet
Copy link
Owner

@kyranet kyranet commented Apr 3, 2020

To install:

  • npm i kyranet/canvasConstructor#refactor/cleaned-up-all-code
  • yarn add kyranet/canvasConstructor#refactor/cleaned-up-all-code

Fixes #341

@NTMNathan
Copy link

Alright, I just did a NPM install of the refractor and tested this patch. To confirm, the filters you said in my issue post are working except convolute. For darkness, to achieve the darkness, the value has to be negative number, for example: .process(darkness, -140).

blur, darkness, sharpen, convolute are having issues, they keep giving me the TypeError: ImageData expected error hence you said that fixing convolute should have fixed the blur and sharpen. It didn't for me...

@kyranet kyranet merged commit 27bfd7c into master Apr 3, 2020
@kyranet kyranet deleted the refactor/cleaned-up-all-code branch April 3, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sepia and Invert Effects work but why not the rest?

3 participants