feat(FR-1220): Add duplicate check logic for session and service names #3937

hummingbbird · 2025-07-11T00:33:11Z

Resolves #3920 (FR-1220)

description

update validation messages for session/service names.

Modify ambiguous expressions
update the validation logic to clarify ambiguous expressions.
add validation logic for duplicated name
add a function to check for duplicate names using an existing GraphQL query.

to reviewers

Although many files were changed, most of them are i18n files, so I committed them all at once.

graphite-app · 2025-07-11T00:33:20Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

github-actions · 2025-07-11T00:35:17Z

Coverage report for `./react`

St.^❔	Category	Percentage	Covered / Total
🔴	Statements	4.52% (-0.01% 🔻)	492/10883
🔴	Branches	4.02% (-0.01% 🔻)	306/7616
🔴	Functions	2.63% (-0% 🔻)	91/3462
🔴	Lines	4.48% (-0.01% 🔻)	477/10646

Show new covered files 🐣

St.^❔	File	Statements	Branches	Functions	Lines
🔴	`...` / useValidateSessionName.tsx	0%	0%	0%	0%
🔴	`...` / useValidateServiceName.tsx	0%	0%	0%	0%

Test suite run success

159 tests passing in 15 suites.

Report generated by 🧪jest coverage report action from 0a257b9

hummingbbird · 2025-07-11T04:27:09Z

feat(FR-1220): Add duplicate check logic for session and service names #3937 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

nowgnuesLee

It seems like a good idea to make it possible to tell from the PR title what the PR fixes. Example. Add name duplication check before creating session and service

resources/i18n/fr.json

nowgnuesLee · 2025-07-11T04:40:45Z

resources/i18n/en.json

    "ServiceCreated": "Model service {{ name }} has been created successfully.",
    "ServiceDelegatedFrom": "Model service is created by {{ createdUser }} but the session ownership will be delegated to {{ sessionOwner }}",
    "ServiceEndpoint": "Service Endpoint",
    "ServiceInfo": "Service Info",
-    "ServiceName": "Service Name",
+    "ServiceName": "Service name",


please use uppercase.

I modified this because everywhere else uses 'service name'. so, can i change all instances to uppercase for consistency?

we're using uppercase in the service form, so I think it's good to use it.

I see. you mean fix only that instance into uppercase? i'll fix that way.

please fix here.

please fix here. @hummingbbird

resources/i18n/en.json

react/src/components/ServiceLauncherPageContent.tsx

hummingbbird · 2025-07-11T05:49:48Z

It seems like a good idea to make it possible to tell from the PR title what the PR fixes. Example. Add name duplication check before creating session and service

I did it because of the character limit. I'll try to edit it like that😃

nowgnuesLee

LGTM

yomybaby

Let's make custom hooks for validation rules of session and service names

react/src/components/ComputeSessionNodeItems/EditableSessionName.tsx

react/src/hooks/useValidateServiceName.tsx

react/src/hooks/useValidateSessionName.tsx

resources/i18n/fr.json

nowgnuesLee · 2025-07-18T05:33:35Z

resources/i18n/en.json

    "ServiceCreated": "Model service {{ name }} has been created successfully.",
    "ServiceDelegatedFrom": "Model service is created by {{ createdUser }} but the session ownership will be delegated to {{ sessionOwner }}",
    "ServiceEndpoint": "Service Endpoint",
    "ServiceInfo": "Service Info",
-    "ServiceName": "Service Name",
+    "ServiceName": "Service name",


please fix here.

…e to service and session name input

react/src/hooks/useValidateServiceName.tsx

react/src/hooks/useValidateSessionName.tsx

nowgnuesLee · 2025-07-21T02:01:48Z

resources/i18n/en.json

    "ServiceCreated": "Model service {{ name }} has been created successfully.",
    "ServiceDelegatedFrom": "Model service is created by {{ createdUser }} but the session ownership will be delegated to {{ sessionOwner }}",
    "ServiceEndpoint": "Service Endpoint",
    "ServiceInfo": "Service Info",
-    "ServiceName": "Service Name",
+    "ServiceName": "Service name",


please fix here. @hummingbbird

yomybaby

Please re-request. review after reviewing my commits.

yomybaby

LGTM!

react/src/hooks/useValidateServiceName.tsx

hummingbbird requested review from yomybaby, agatha197 and nowgnuesLee July 11, 2025 00:33

hummingbbird self-assigned this Jul 11, 2025

github-actions bot added area:ux UI / UX issue. area:i18n Localization size:XL 500~ LoC labels Jul 11, 2025

hummingbbird force-pushed the feat/add-duplicate-check-logic-and-modify-validation-message-to-service-and-session-name-input branch from 53dd8e6 to a99992d Compare July 11, 2025 04:26

nowgnuesLee requested changes Jul 11, 2025

View reviewed changes

hummingbbird force-pushed the feat/add-duplicate-check-logic-and-modify-validation-message-to-service-and-session-name-input branch from a99992d to dec2fe2 Compare July 11, 2025 05:47

hummingbbird changed the title ~~feat(FR-1120): modify session and service name validation logic~~ feat(FR-1120): add name duplicate check logic for session/service names Jul 11, 2025

hummingbbird changed the title ~~feat(FR-1120): add name duplicate check logic for session/service names~~ feat(FR-1120): Add name duplicate check logic for session and service names Jul 11, 2025

hummingbbird requested a review from nowgnuesLee July 11, 2025 06:14

hummingbbird changed the title ~~feat(FR-1120): Add name duplicate check logic for session and service names~~ feat(FR-1120): Add duplicate check logic for session and service names Jul 11, 2025

hummingbbird force-pushed the feat/add-duplicate-check-logic-and-modify-validation-message-to-service-and-session-name-input branch from dec2fe2 to f4a30fe Compare July 11, 2025 07:27

github-actions bot added size:L 100~500 LoC and removed size:XL 500~ LoC labels Jul 11, 2025

hummingbbird force-pushed the feat/add-duplicate-check-logic-and-modify-validation-message-to-service-and-session-name-input branch from f4a30fe to 66fb7ea Compare July 11, 2025 07:42

nowgnuesLee approved these changes Jul 11, 2025

View reviewed changes

yomybaby changed the title ~~feat(FR-1120): Add duplicate check logic for session and service names~~ feat(FR-1220): Add duplicate check logic for session and service names Jul 15, 2025

yomybaby requested changes Jul 15, 2025

View reviewed changes

react/src/components/ComputeSessionNodeItems/EditableSessionName.tsx Outdated Show resolved Hide resolved

hummingbbird force-pushed the feat/add-duplicate-check-logic-and-modify-validation-message-to-service-and-session-name-input branch 3 times, most recently from f157499 to 330e05a Compare July 16, 2025 04:22

hummingbbird requested review from nowgnuesLee and yomybaby July 16, 2025 04:26

nowgnuesLee requested changes Jul 16, 2025

View reviewed changes

react/src/hooks/useValidateServiceName.tsx Outdated Show resolved Hide resolved

react/src/hooks/useValidateSessionName.tsx Outdated Show resolved Hide resolved

hummingbbird force-pushed the feat/add-duplicate-check-logic-and-modify-validation-message-to-service-and-session-name-input branch from 330e05a to 85ce962 Compare July 18, 2025 01:06

hummingbbird requested a review from nowgnuesLee July 18, 2025 04:06

nowgnuesLee requested changes Jul 18, 2025

View reviewed changes

hummingbbird force-pushed the feat/add-duplicate-check-logic-and-modify-validation-message-to-service-and-session-name-input branch from 85ce962 to 7cf9a49 Compare July 18, 2025 08:57

feat(FR-1120): add duplicate check logic and modify validation messag…

b775ea5

…e to service and session name input

hummingbbird force-pushed the feat/add-duplicate-check-logic-and-modify-validation-message-to-service-and-session-name-input branch from 7cf9a49 to b775ea5 Compare July 21, 2025 00:39

hummingbbird requested a review from nowgnuesLee July 21, 2025 00:42

nowgnuesLee requested changes Jul 21, 2025

View reviewed changes

yomybaby force-pushed the feat/add-duplicate-check-logic-and-modify-validation-message-to-service-and-session-name-input branch from 7297c6f to 9485f3e Compare July 21, 2025 02:39

hummingbbird force-pushed the feat/add-duplicate-check-logic-and-modify-validation-message-to-service-and-session-name-input branch from 9485f3e to 96a761c Compare July 21, 2025 06:36

yomybaby requested changes Jul 21, 2025

View reviewed changes

hummingbbird requested review from yomybaby and nowgnuesLee July 21, 2025 06:59

yomybaby approved these changes Jul 21, 2025

View reviewed changes

nowgnuesLee requested changes Jul 21, 2025

View reviewed changes

react/src/hooks/useValidateServiceName.tsx Outdated Show resolved Hide resolved

hummingbbird force-pushed the feat/add-duplicate-check-logic-and-modify-validation-message-to-service-and-session-name-input branch from 96a761c to 1503ba8 Compare July 21, 2025 07:38

hummingbbird requested review from nowgnuesLee and yomybaby July 21, 2025 07:38

nowgnuesLee requested changes Jul 21, 2025

View reviewed changes

react/src/hooks/useValidateServiceName.tsx Outdated Show resolved Hide resolved

hummingbbird force-pushed the feat/add-duplicate-check-logic-and-modify-validation-message-to-service-and-session-name-input branch from 1503ba8 to 9637f37 Compare July 21, 2025 07:52

hummingbbird requested a review from nowgnuesLee July 21, 2025 07:53

hummingbbird force-pushed the feat/add-duplicate-check-logic-and-modify-validation-message-to-service-and-session-name-input branch 2 times, most recently from 6738bae to a769c8d Compare July 21, 2025 08:23

Refactor and bugfix related to duplicated name validation

0a257b9

hummingbbird force-pushed the feat/add-duplicate-check-logic-and-modify-validation-message-to-service-and-session-name-input branch from a769c8d to 0a257b9 Compare July 21, 2025 09:24

feat(FR-1220): Add duplicate check logic for session and service names #3937

Are you sure you want to change the base?

feat(FR-1220): Add duplicate check logic for session and service names #3937

Conversation

hummingbbird commented Jul 11, 2025 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

description

to reviewers

Uh oh!

graphite-app bot commented Jul 11, 2025

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report for ./react

Test suite run success

Uh oh!

hummingbbird commented Jul 11, 2025

How to use the Graphite Merge Queue

Uh oh!

nowgnuesLee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hummingbbird commented Jul 11, 2025

Uh oh!

nowgnuesLee left a comment

Choose a reason for hiding this comment

Uh oh!

yomybaby left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yomybaby left a comment

Choose a reason for hiding this comment

Uh oh!

yomybaby left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hummingbbird commented Jul 11, 2025 •

edited by jira bot

Loading

github-actions bot commented Jul 11, 2025 •

edited

Loading

Coverage report for `./react`