Echo v5

[vishr]

Let me know what you want to see in v5 ✌️

Here are my thoughts?

• I don't like Context as an interface, we did it to expand on it using a custom context; however, casting it back in handler is tedious
• Simplified middleware signature like in v1/v2? making it easier to write a middleware.
• Bind path parameters
• Merge feat: Add a new ErrorHandlerWithContext #1328 with JWTErrorHandler (How about adding next to the handler so you can rely on next auth handler)

[QuantumGhost]

I'd like to know if we can make #1214 in v5.

[zxysilent]

Consider using only one log module

[vishr]

Consider using only one log module

Which one?

[zxysilent]

Consider using only one log module

Which one?

[harshachandra]

StdLogger looks fine to me provided we have "bring your own logger" option is given.
And similarly can we bring own Router like we have option to set Validator?

[mei-rune]

I like it Context as interface, but need improve now code.

add methods:

(e *Echo) SetNewContext(newCtx  func() Context) {
 e.pool.New = func() interface{} {
		return newCtx()
	}
}

func (e *Echo) ServeHTTP(w http.ResponseWriter, r *http.Request) {
	c := e.pool.Get().(Context)
	c.Reset(r, w)
	......
	c.Free()
	e.pool.Put(c)
}

my client code:

type MyContext strcut {
	echo.Context
	
	MyField1 xxx
	MyField2 xxx
	MyField3 xxx
	.... xxx
}

func (ctx *MyContext) Free() {
   ctx.MyField1 = nil
   ctx.MyField2 = nil
   ctx.MyField3 = nil
   ....
}

func toEchoFunc(h func(ctx *MyContext) error) echo.HandlerFunc {
	return func(ctx echo.Context) error {
		return h(ctx.(*MyContext))
	}
}

echo.SetNew(func() echo.Context {
	return &MyContext{Context: echo.NewContext()}
})

echo.GET("/xxx", toEchoFunc(func(ctx *MyContext) error {
   xxxxxxx
}))

[mei-rune]

add gin.IRoutes(iris.Party) interface.

  e := echo.New()
  initHandlers(e)     // now is error
  initHandlers(e.Group("/")) 
  ...

func initHandlers(g *echo.Group) {
  g.Get("/x", a)
  g.Get("/y", a)
}

[universonic]

How about #1261 ?

[mei-rune]

add NoRoute?
#900
#856

[awbraunstein]

I think that echo.Context should implement context.Context. This way deadlines to backends could be correctly propagated as well as tracing data.

[harshachandra]

Can we have an examples section describing the existing APIs from https://godoc.org/gopkg.in/labstack/echo.v4 or going forward https://godoc.org/gopkg.in/labstack/echo.v5? They can be hosted from https://echo.labstack.com/

[alexaandru]

• I don't like Context as an interface, we did it to expand on it using a custom context; however, casting it back in handler is tedious.
  I do like it, the casting is a very small price to pay for the convenience of adding your own logic on top of echo.Context

• Simplified middleware signature like in v1/v2? making it easier to write a middleware.
  We could move the middleware in a separate repo, each in their own subfolders/Go modules. That way they can evolve at different pace.

[mei-rune]

@aimeelaplant I don't llke that echo.Context should implement context.Context.
but I think context.Context as a Field in echo.Context is good idea.