BodyLimit middleware: (r *limitedReader) Reset does not reset read counter #1085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1085 +/- ##
==========================================
+ Coverage 80.86% 80.98% +0.11%
==========================================
Files 27 27
Lines 1892 1893 +1
==========================================
+ Hits 1530 1533 +3
+ Misses 254 253 -1
+ Partials 108 107 -1
Continue to review full report at Codecov.
|
vishr
approved these changes
Mar 16, 2018
|
@florianholzapfel thanks for your contribution 🎉 |
|
thank you for this awesome project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The limitedReader in the body limit middleware does not reset its read counter when calling the Reset method.
This PR fixes this and also adds a test for this case.