Clean old Go versions #1100
Merged
Clean old Go versions #1100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1100 +/- ##
==========================================
+ Coverage 81.06% 81.14% +0.08%
==========================================
Files 27 25 -2
Lines 1901 1899 -2
==========================================
Hits 1541 1541
+ Misses 253 250 -3
- Partials 107 108 +1
Continue to review full report at Codecov.
|
vishr
reviewed
Apr 3, 2018
echo.go
Outdated
| @@ -729,6 +749,11 @@ func handlerName(h HandlerFunc) string { | |||
| return t.String() | |||
| } | |||
|
|
|||
| // PathUnescape is wraps `url.PathUnescape` | |||
| func PathUnescape(s string) (string, error) { | |||
There was a problem hiding this comment.
We can drop this function and directly use url.PathUnescape - wherever it is being used.
vishr
approved these changes
Apr 3, 2018
|
@alexandrestein again, thanks for your contribution 🎉 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Travis checks only from
Go 1.9; we can maybe clean the specific builds.