Fix node's parameter names assignment problem #1201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixed the issues(#1052, #1139) on which the parameters cannot be obtained on some paths defined as having the same prefix but with different parameter names.
This issue is caused because the
node.pnames
of shorter paths is overwritten by the node of longer paths inserted.With this change, I managed to apply the changes to the
pnames
of a specific node only when the appending node corresponds to the end of URL's path.I added the following test cases (#1052 and #1139). We have confirmed that the behavior is as expected.
However, this commit does not fix the case (#1139) found below because it needs to store
ppath
andpnames
for each HTTP method like amethodHandler
.