Skip to content

High res captures and changing stream resolution #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 15, 2025
Merged

Conversation

JohemianKnapsody
Copy link
Collaborator

Adds functions to take high res captures and restart the stream in a low video quality, high capture quality mode

@JohemianKnapsody JohemianKnapsody marked this pull request as ready for review May 9, 2025 11:00
Copy link
Contributor

@julianstirling julianstirling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments.

I'm not sure whether we used the full-res capture array anywhere wasn't this slower and less reliable?

@JohemianKnapsody
Copy link
Collaborator Author

Something during today's changes seems to have made stitching a scan less reliable, with worse correlations. Wondering whether buffer count affects autofocus affects quality of image affects stitching correlations?

@JohemianKnapsody
Copy link
Collaborator Author

Something during today's changes seems to have made stitching a scan less reliable, with worse correlations. Wondering whether buffer count affects autofocus affects quality of image affects stitching correlations?

I'm happy to say this may have been due to something else, after redoing camera stage mapping and camera calibration all was fine. Made buffer_count an argument, think this is ready to release

@julianstirling
Copy link
Contributor

Great, thanks Joe. I think buffer_count defaulting to the picamera2 standard of 6 is good. It allows us to adjust it when doing high res if needed.

@julianstirling julianstirling merged commit 1b051bd into main May 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants