Skip to content

chore(deps): update dependency vitest to v4.1.2 #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lacolaco merged 5 commits into from
Apr 2, 2026
Merged

chore(deps): update dependency vitest to v4.1.2 #1342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bdadfa8
chore(deps): update dependency vitest to v4.1.2
renovate[bot] Apr 1, 2026
298578f
fix: move embed spec file out of pages directory
lacolaco Apr 1, 2026
814243b
refactor: extract fetchPageMetadata to src/libs/embed/
lacolaco Apr 2, 2026
fcd9149
fix: resolve relative image URLs and clarify retry log message
lacolaco Apr 2, 2026
be40cc5
fix: skip empty string image URLs in extractImageUrl
lacolaco Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"tailwindcss": "4.2.2",
"tsx": "4.21.0",
"typescript-eslint": "^8.33.1",
"vitest": "4.0.18",
"vitest": "4.1.2",
"zod": "^3.22.4"
}
}
156 changes: 72 additions & 84 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

44 changes: 43 additions & 1 deletion src/pages/embed/index.spec.ts → src/libs/embed/fetchPageMetadata.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { describe, it, expect, vi, beforeEach } from 'vitest';
import { fetchPageMetadata } from './index';
import { fetchPageMetadata } from './fetchPageMetadata';

// fetchをモック
const mockFetch = vi.fn();
Expand Down Expand Up @@ -109,6 +109,48 @@ describe('fetchPageMetadata', () => {
expect(mockFetch).toHaveBeenCalledTimes(2);
});

it('相対URLの画像パスを絶対URLに解決する', async () => {
mockFetch.mockResolvedValueOnce({
ok: true,
status: 200,
headers: new Headers(),
text: () =>
Promise.resolve(`
<html>
<head>
<title>Relative Image Test</title>
<meta property="og:image" content="/images/hero.jpg" />
</head>
</html>
`),
});

const result = await fetchPageMetadata('https://example.com/page');

expect(result.imageUrl).toBe('https://example.com/images/hero.jpg');
});

it('空文字列のog:imageをスキップする', async () => {
mockFetch.mockResolvedValueOnce({
ok: true,
status: 200,
headers: new Headers(),
text: () =>
Promise.resolve(`
<html>
<head>
<title>Empty Image Test</title>
<meta property="og:image" content="" />
</head>
</html>
`),
});

const result = await fetchPageMetadata('https://example.com');

expect(result.imageUrl).toBeNull();
});

it('無効なURLでもエラーをスローせずフォールバックする', async () => {
mockFetch.mockResolvedValue({
ok: false,
Expand Down
Loading
Loading