Repository navigation
fix(nn.utils.prune): don't crash adding a method to an empty PruningContainer - #89
Open
laifenxiawucha wants to merge 1 commit into
Open
laifenxiawucha wants to merge 1 commit into
laifenxiawucha wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an
AttributeErrorintorch.nn.utils.prune.PruningContainerwhen a method is added to an empty container.Root Cause
PruningContainer.add_pruning_methodassumed_tensor_namehad already been initialized. ForPruningContainer()followed byadd_pruning_method(...), that attribute was missing, so the first add raisedAttributeErrorinstead of adopting the method's tensor name.Changes
PruningContaineradopt_tensor_namefrom the first added pruning methodVerification
Used the issue reproducer with the patched
torch.nn.utils.prunemodule loaded from this branch in the provided XPU Python environment:Observed:
Issue: https://github.com/intel-sandbox/torch-xpu-ops-exp/issues/1895