Repository navigation
Fix ldexp grad for negative exponents - #91
Open
laifenxiawucha wants to merge 1 commit into
Open
laifenxiawucha wants to merge 1 commit into
laifenxiawucha wants to merge 1 commit into
Conversation
laifenxiawucha
force-pushed
the
agent/fix-ldexp-negative-exponent-grad
branch
from
July 7, 2026 19:55
0f0c493 to
c6e75ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/intel-sandbox/torch-xpu-ops-exp/issues/1929
The ldexp autograd formula used at::pow(2, other), which follows integer pow semantics when
otheris an integer tensor. For negative exponents this evaluates to zero, so gradients with respect toselfare incorrect. Use the floating overload, at::pow(2.0, ...), for both backward and forward AD formulas, and add a regression test for negative exponents.Test: python3 -m py_compile test/test_binary_ufuncs.py; python3 test/test_binary_ufuncs.py TestBinaryUfuncs.test_ldexp_backward_negative_exponent (blocked: missing expecttest in local environment)