Skip to content

Commit 6b053bd

Browse files
authored
fix(l1): ignore error on hive makefile targets (#2914)
**Motivation** When running `make run-hive SIMULATION=...` and any of the tests failed, the hiveview would not open and we could not visualize the tests on the browser **Description** The error is ignored when running the hive simulation so the hiveview can be built and executed. <!-- Link to issues: Resolves #111, Resolves #222 -->
1 parent d3d6217 commit 6b053bd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,11 +128,11 @@ display-hive-alternatives:
128128
# For example, to run the rpc-compat suites for eth_chainId & eth_blockNumber you should run:
129129
# `make run-hive SIMULATION=ethereum/rpc-compat TEST_PATTERN="/eth_chainId|eth_blockNumber"`
130130
run-hive: display-hive-alternatives build-image setup-hive ## 🧪 Run Hive testing suite
131-
cd hive && ./hive --client $(L1_CLIENT) --ethrex.flags "--evm $(EVM_BACKEND) --syncmode $(SYNCMODE)" --sim $(SIMULATION) --sim.limit "$(TEST_PATTERN)" --sim.parallelism "$(SIM_PARALLELISM)"
131+
- cd hive && ./hive --client $(L1_CLIENT) --ethrex.flags "--evm $(EVM_BACKEND) --syncmode $(SYNCMODE)" --sim $(SIMULATION) --sim.limit "$(TEST_PATTERN)" --sim.parallelism "$(SIM_PARALLELISM)"
132132
$(MAKE) view-hive
133133

134134
run-hive-all: display-hive-alternatives build-image setup-hive ## 🧪 Run all Hive testing suites
135-
cd hive && ./hive --client $(L1_CLIENT) --ethrex.flags "--evm $(EVM_BACKEND) --syncmode $(SYNCMODE)" --sim ".*" --sim.parallelism "$(SIM_PARALLELISM)"
135+
- cd hive && ./hive --client $(L1_CLIENT) --ethrex.flags "--evm $(EVM_BACKEND) --syncmode $(SYNCMODE)" --sim ".*" --sim.parallelism "$(SIM_PARALLELISM)"
136136
$(MAKE) view-hive
137137

138138
run-hive-debug: display-hive-alternatives build-image setup-hive ## 🐞 Run Hive testing suite in debug mode

0 commit comments

Comments
 (0)