feat: compute receipts root #111

ricomateo · 2024-07-02T18:18:42Z

Closes #106

**Motivation** Replace evm code in eftests with an implementation that uses ethrex types **Description** * Implement `execute_tx` using revm * Move `evm` crate into `core` crate * Move `Transaction` into its own module * Implement multiple getters for `Transaction` fields * Implement address recovery from signed transactions * Implement conversions between ef tests types and ethrex types * Add one more ef test  Closes #21

the value must be rlp(receipt) instead of tx_type || rlp(receipt) (if tx_type != 0)

the previous way in which the receipts trie values were computed was the right way

crates/core/src/types/block.rs

MegaRedHand

LGTM

**Motivation**  **Description**   Closes #issue_number

**Motivation** Obtain world state from account info stored in db **Description** * Implement storage root computation * Implement word state  Closes #44

**Motivation** Add support for EIP2930 transaction **Description** Implements EIP2930Transaction + required methods & traits   Closes None, but will enable #135 to also close #24

This PR is based on #138 (as they modify the same code), please merge it first **Motivation** Add support for EIP4844 transactions  **Description** Add `EIP4844` transactions + needed trait and methods and integrate it into existing transaction-related code   Closes #26 (evm already performs validations before executing so adding the transaction itself will sufice)

**Motivation** Add error handling to `execute_tx` and remove unwrap  **Description** Add `EvmError` Map revm's `EVMError` to `EvmError` Add error handling to `execute_tx`   Closes None

**Motivation**  **Description**   Closes #125 --------- Co-authored-by: Tomás Grüner <[email protected]>

**Motivation** Being able to store and fetch blocks from the db via `Store` api **Description** * Replace `Transaction::encode` with `Transaction::encode_with_type` logic (Reasoning: We cannot decode the transactions without knowing their type with the current behaviour, making it impossible to implement `RLPDecode` for `Transaction`) * Implement `RLPDecode` for `Transaction` (Using the logic that was previoulsy used in `EncodedTransaction::decode` (payload module)) * Implement `RLPDecode` for `Withdrawal`, `BlockHeader` and `BlockBody` * Add the folloewng methods to `Store` and `StoreEngine`: `add_block_header`, `add_block_body`, `get_block_header`, `get_block_body`, and implement them for `InMemory` and `Libmdbx` engine types   Closes None, but is needed for #145

**Motivation** Being able to serialize blocks matching the output required by the rpc spec  **Description** *Add struct `BlockSerializable` which can be serialized to match the specifications of the rpc. It can contain either the full transactions or just their hashes. *Implement serialization for `BlockSerializable`, `BlockHeader`, `BlockBody`, `Withdrawal` and `Transaction`. Other changes: *Replace `Bloom` with `ethereum_types::Bloom` *Rename some fields in `Eip1559Transaction` to match other transaction types' fields   Closes None, but is needed in order to implement #31

**Motivation**  If CI fails, docker images may not be updated **Description** Add instructions on how to do it manually

**Motivation**  **Description**   Closes #issue_number Co-authored-by: Ivan Litteri <[email protected]>

This reverts commit c7ec3b3. **Motivation** Multiple tests for Paris fork started failing on hive eest consume-engine and consume-rlp suites as of merging this PR. Noticed by `Hive Daily Report` workflow  **Description**

**Motivation**  Migrations of SQL schema are tricky. If new tables were added, it has to be migrated manually. **Description**  Make SQL schema setup sentences idempotent so they can be executed on every start up.

**Motivation**  We want to offer ARM Docker images for both L1 and L2. **Description**  Add support for ARM images and update CI release workflows to build so.  Closes #3667

**Motivation** Addressing #5344 by using the existing `block_hash_cache` to store block hashes looked up during `BLOCKHASH` opcode execution to speed up subsequent lookups  **Description** * Add interior mutability to block_hash_cache (HashMap -> Arc<Mutex<BTreeMap>>) * Insert block hashes obtained during lookup to block_hash_cache (BLOCKHASH opcode) * Use oldest cached block successor to shortcut ancestor lookup (BLOCKHASH opcode)  Benchmark Results: x33,6 improvement on BlockHash EEST gas benchmark: 1080.92 Mgas/s vs 32.18 Gas/s on main (7b4a0ba)  Closes #5344 --------- Co-authored-by: Edgar <[email protected]>

**Motivation** * This would also allow us to filter out peers on wrong network or fork. **Description** * uses similar flow as lookup * store node records for future purposes such as filtering nodes on forkid and rlpx connections(#5423)  Towards #5423 --------- Co-authored-by: lakshya-sky <[email protected]>

**Motivation** Geth uses forkId for making connection as outlined in below posts and failing to provide one could mean that newer Geth clients would reject connections. https://ethereum-magicians.org/t/all-core-devs-testing-acdt-46-july-28-2025/24889/6 and ethereum/go-ethereum#31944. **Description**   Closes #5066 --------- Co-authored-by: lakshya-sky <[email protected]> Co-authored-by: Tomás Grüner <[email protected]>

**Motivation**  **Description**   Closes #issue_number

**Motivation** The l2 ci runs on any change in the fixture directory, we want it to run on certain paths.  **Description** Specify which paths under fixtures the l2 ci should run on.

**Motivation** We want to be able to send funds and call contracts from one L2 to another without having to pass through the L1 **Description** This PR adds the necessary changes to send funds and call contracts between 2 L2s. You can find details under `shared_bridge_steps.md` and `shared_bridge.md`.   --------- Co-authored-by: Gianbelinche <[email protected]> Co-authored-by: ilitteri <[email protected]> Co-authored-by: Ivan Litteri <[email protected]> Co-authored-by: Tomás Paradelo <[email protected]>

…5322) **Motivation** Periodically checking and informing the user if there is a newer version of ethrex available  **Description** * Periodically query the latest relese of ethrex on GitHub and check against current running version, inform the user via log if there is a newer version available.   --------- Co-authored-by: Tomás Grüner <[email protected]>

) **Motivation**  We don't need to specify the `platform` for the docker image anymore, as we now build it for both `amd64` and `arm64`. Also, `amd64` images are not working anymore on arm machines due to AVX. **Description**  Remove the platform specified in the root's docker compose so it auto-detects which to use.

**Motivation**  **Description**   Closes #5488 --------- Co-authored-by: lakshya-sky <[email protected]> Co-authored-by: ElFantasma <[email protected]>

**Motivation**  **Description**   **Checklist** - [ ] Updated `STORE_SCHEMA_VERSION` (crates/storage/lib.rs) if the PR includes breaking changes to the `Store` requiring a re-sync. Closes #5574 and #5575. Co-authored-by: Esteban Dimitroff Hodi <[email protected]>

**Motivation**  - These are improvements of things I've noticed by looking at the docs **Description**   This is a follow up of #5523

**Motivation**  **Description**   **Checklist** - [ ] Updated `STORE_SCHEMA_VERSION` (crates/storage/lib.rs) if the PR includes breaking changes to the `Store` requiring a re-sync.

**Motivation** We want to add the performance improvement done in L1 with the block pipelining also for the L2.  **Description** Adds the `add_l2_block_pipeline` function to the blockchain and uses it for regenerating the blockchain from checkpoints.   --------- Co-authored-by: Ivan Litteri <[email protected]> Co-authored-by: ilitteri <[email protected]>

**Motivation**  **Description**   **Checklist** - [ ] Updated `STORE_SCHEMA_VERSION` (crates/storage/lib.rs) if the PR includes breaking changes to the `Store` requiring a re-sync. Closes #5570 Closes #5571

**Motivation**  Solidity started publishing ARM binaries since version `0.8.31`. **Description**  Update contracts and workflows to use that version and simplify installation processes.

**Motivation** Adding logs to grafana as part of the local monitoring stack **Description** This PR add loki and promtail to our current metics docker compose. To maintain compatibility with how we are currently running we made a couple of decisions: - Continue logging on stdout by default - Add a new `--log.dir` cli param which enables logging files (alongside the stdout) - Use `./logs` by default in the repo as the folder from which take logs (and make them configurable by an env variable) - Add a new Logs row (collapsed by default) to our dashboard. - Add documentation and update the dashboard docs <img width="2248" height="1030" alt="image" src="https://github.com/user-attachments/assets/19c6849f-9aea-4329-a5f8-3b2b171c731a" /> **Next Steps** There are a couple of things to improve: - This set up is working for local execution but not for centralized ones, we mnight need some changes to how loki and promtail interacts for that - The docker-compose now continue to works as default (`STDOUT`) we might want to move to add logs and show them on dashboards by default in the future. That might also require to launch the metric related services.  Closes #3265

**Motivation**  **Description**   --------- Co-authored-by: Pablo Deymonnaz <[email protected]> Co-authored-by: Tomás Grüner <[email protected]>

**Motivation**  **Description**

**Motivation** Expose ethrex version as a metric to avoid depending on ethereum-metrics-exporter for it. **Description** This PR adds `ethrex_info` as a new metric that expose version, build related information, and network. ``` # HELP ethrex_info Node information including version and build details # TYPE ethrex_info gauge ethrex_info{branch="expose-ethrex-version",commit="5e88113",network="hoodi",rust_version="1.90.0",target="aarch64-apple-darwin",version="7.0.0"} 1 ``` This allowed us to stop relying on `ethereum-metrics-exporter` on our L1 dashboard (except for the fork one which we'll need a different approach and a follow-up PR), the dashboard and docs are updated. <img width="2548" height="300" alt="image" src="https://github.com/user-attachments/assets/2348c46f-0a65-44e5-bb38-6d5de59fe803" /> There is also a small change in how we treat gather metric error for the first metrics configured to be consistent with what we are doing today.  Resolves #5549

**Motivation**  **Description**

…ble (#5724) **Motivation**  Upgradeable contracts cannot have initial values in variable declaration. Instead, they need to be initialized in an initializer. **Description**  Remove initial value from `SHARED_BRIDGE_ROUTER`.

**Motivation**  L1 tests are compiling L2 packages. We noticed it in [this CI run](https://github.com/lambdaclass/ethrex/actions/runs/20462543412/job/58798420057) **Description**  Exclude `ethrex-prover` and `guest_program` packages from L1 CI tests. Changed `ethrex-l2` with `ethrex-l2*` to also exclude other L2 packages

**Motivation** #5535 introduced a version of ecadd that uses substrate-bn, because both ZisK and SP1 patch this crate to use zkVM accelerators for the operation. After merging, we found an Ethereum Mainnet block failing to execute with a gas mismatch error, which does not happen one commit before merging that PR. This PR reverts the usage of substrate-bn for SP1 only. **Description**   **Checklist** - [ ] Updated `STORE_SCHEMA_VERSION` (crates/storage/lib.rs) if the PR includes breaking changes to the `Store` requiring a re-sync. Closes #issue_number

**Motivation** Removes needless allocations due to the current api requiring a ref to a Vec **Description**   **Checklist** - [ ] Updated `STORE_SCHEMA_VERSION` (crates/storage/lib.rs) if the PR includes breaking changes to the `Store` requiring a re-sync. Closes #issue_number --------- Co-authored-by: Pablo Deymonnaz <[email protected]>

MegaRedHand and others added 10 commits July 1, 2024 13:03

feat: compute transactions root for a block

a685ff2

fix: was encoding LegacyTransaction incorrectly

611bc86

fix: RLP encode index

49f0374

Merge branch 'main' into compute-transactions-root

7080893

Merge branch 'main' into compute-transactions-root

5f9e6eb

refactor: add Transaction::encode_with_type

a81897f

refactor: add TxType enum for encoding tx type

b966cf4

refactor: add TxKind struct

2c59b6d

Merge branch 'main' into compute-transactions-root

830ecac

add receipts root computation

67f1db0

ricomateo added 4 commits July 2, 2024 17:07

fix: the receipt trie value was being computed wrong

3f2dac6

the value must be rlp(receipt) instead of tx_type || rlp(receipt) (if tx_type != 0)

fix: compute receipts trie value correctly

8e23699

the previous way in which the receipts trie values were computed was the right way

remove unnecessary constructor

3b32d29

merge main

ff376e1

ricomateo marked this pull request as ready for review July 2, 2024 20:59

ricomateo requested a review from a team as a code owner July 2, 2024 20:59

MegaRedHand reviewed Jul 2, 2024

View reviewed changes

crates/core/src/types/block.rs Outdated Show resolved Hide resolved

fix: move compute_receipts_root out of BlockBody impl

f02abf1

MegaRedHand approved these changes Jul 3, 2024

View reviewed changes

MegaRedHand merged commit b3a16bf into main Jul 3, 2024

MegaRedHand deleted the compute-receipts-root branch July 3, 2024 13:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: compute receipts root #111

feat: compute receipts root #111

Uh oh!

ricomateo commented Jul 2, 2024

Uh oh!

Uh oh!

MegaRedHand left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: compute receipts root #111

feat: compute receipts root #111

Uh oh!

Conversation

ricomateo commented Jul 2, 2024

Uh oh!

Uh oh!

MegaRedHand left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants