feat: compute receipts root #111

ricomateo · 2024-07-02T18:18:42Z

Closes #106

**Motivation** Replace evm code in eftests with an implementation that uses ethrex types **Description** * Implement `execute_tx` using revm * Move `evm` crate into `core` crate * Move `Transaction` into its own module * Implement multiple getters for `Transaction` fields * Implement address recovery from signed transactions * Implement conversions between ef tests types and ethrex types * Add one more ef test  Closes #21

the value must be rlp(receipt) instead of tx_type || rlp(receipt) (if tx_type != 0)

the previous way in which the receipts trie values were computed was the right way

crates/core/src/types/block.rs

MegaRedHand

LGTM

**Motivation**  **Description**   Closes #issue_number

**Motivation** Obtain world state from account info stored in db **Description** * Implement storage root computation * Implement word state  Closes #44

**Motivation** Add support for EIP2930 transaction **Description** Implements EIP2930Transaction + required methods & traits   Closes None, but will enable #135 to also close #24

This PR is based on #138 (as they modify the same code), please merge it first **Motivation** Add support for EIP4844 transactions  **Description** Add `EIP4844` transactions + needed trait and methods and integrate it into existing transaction-related code   Closes #26 (evm already performs validations before executing so adding the transaction itself will sufice)

**Motivation** Add error handling to `execute_tx` and remove unwrap  **Description** Add `EvmError` Map revm's `EVMError` to `EvmError` Add error handling to `execute_tx`   Closes None

**Motivation**  **Description**   Closes #125 --------- Co-authored-by: Tomás Grüner <[email protected]>

**Motivation** Being able to store and fetch blocks from the db via `Store` api **Description** * Replace `Transaction::encode` with `Transaction::encode_with_type` logic (Reasoning: We cannot decode the transactions without knowing their type with the current behaviour, making it impossible to implement `RLPDecode` for `Transaction`) * Implement `RLPDecode` for `Transaction` (Using the logic that was previoulsy used in `EncodedTransaction::decode` (payload module)) * Implement `RLPDecode` for `Withdrawal`, `BlockHeader` and `BlockBody` * Add the folloewng methods to `Store` and `StoreEngine`: `add_block_header`, `add_block_body`, `get_block_header`, `get_block_body`, and implement them for `InMemory` and `Libmdbx` engine types   Closes None, but is needed for #145

**Motivation** Being able to serialize blocks matching the output required by the rpc spec  **Description** *Add struct `BlockSerializable` which can be serialized to match the specifications of the rpc. It can contain either the full transactions or just their hashes. *Implement serialization for `BlockSerializable`, `BlockHeader`, `BlockBody`, `Withdrawal` and `Transaction`. Other changes: *Replace `Bloom` with `ethereum_types::Bloom` *Rename some fields in `Eip1559Transaction` to match other transaction types' fields   Closes None, but is needed in order to implement #31

@DiegoCivi

**Motivation** - Fix remaining blockchain tests for Prague with LEVM. **Description** - Precompiles shouldn't be executed in case they are delegation target of the same transaction in which they are being called. - It also fixes a problem in the transfer of value in CALL. (It just moves the place where the value transfer is performed) After this there are no more `blockchain` tests we need to fix.  Co-authored-by: @DiegoCivi

…sit request error (#2832) **Motivation** Currently, when we fail to parse a deposit request we simply ignore it and keep the rest of the deposits, relying on the request hash check afterwards to notice the missing deposit request. This PR handles the error earlier and returns the appropriate `InvalidDepositRequest Error`. This will provide better debugging information and also more accurate testing via tools such as `execution-spec-tests` which rely on specific error returns. We also were not correctly validating the layout according to the [EIP](https://eips.ethereum.org/EIPS/eip-6110), as we were only checking the total size and not the size and offset of each request field  **Description** * Check that the full layout of deposit requests is valid (aka the internal sizes and offsets of the encoded data) * Handle errors when parsing deposit requests * Check log topic matches deposit topic before parsing a request as a deposit request   Allows us to address review comment made on execution-specs-test PR ethereum/execution-spec-tests#1607 + also closes #2132

**Motivation** Support rpc endpoint `admin_peers`  **Description** * Add rpc endpoint `admin_peers` * Track inbound connections * Store peer node version when starting a connection * Add `peer_handler: PeerHandler` field to `RpcContext` so we can access peers from the rpc * (Misc) `Syncer` & `SyncManager` now receive a `PeerHandler` upon creation instead of a `KademliaTable` * (Misc) Fix common typo across the project  Data missing compared to geth implementation: * The local address of each connection * Whether a connection is trusted, static (we have no notion of this yet)  Closes #2671

**Motivation** Multiple version of the same protocol can be used when a connection is established(eth/68 and eth/69 for example). At the moment, we can only use one protocol version.  **Description** A vec of capability is used to pass multiple versions of the protocol to some functions. The struct RLPxConnection now stores capabilities struct instead of numbers.

**Motivation** We were excluding `ethrex-prover-bench` when doing `cargo check --workspace` because it failed when `succinct` was not instaled. **Description** - `sp1` feature was removed from the default features of `ethrex-prover-bench`. - After doing the step above, `cargo check --workspace` could be ran and some errors and warnings appeared and they were fixed. - '--exclude ethrex-prover-bench' was removed from the L1 ci job  Closes #2807

#2863) **Motivation**  **Description**   Closes #issue_number Co-authored-by: Tomás Arjovsky <[email protected]>

**Motivation** `Block` had the hash but the `BlockHeader` didn't so they had to be passed along together.  **Description** Move the hash into `BlockHeader`, making it accesible to it and also to `Block`   Closes #2841

…#2871) **Motivation**  **Description** - Update blockchain tests from 4.3.0 to 4.5.0 - Update state tests from pectra-devnet-6 to 4.5.0 - Remove tests from old forks (Constantinople folder)  Closes #issue_number

**Motivation** Run the hiveview as default when running hive tests for a better visualization **Description** New makefile target that builds and executes the hiveview with the logs created when running hive tests

**Motivation** Adds an RPC method that allows reading all transactions currently in the mempool. This endpoint was based off of Geth's `txpool_content` endpoint ([doc](https://geth.ethereum.org/docs/interacting-with-geth/rpc/ns-txpool#txpool-content)) and follows the same response logic & format. As we have no notion of `queued` mempool transactions currenlty, this field will be permanently left empty The namescape and endpoint currently uses `txpool` instead of `mempool` for immediate compatibility with components compatible with geth, we should consider changing the name back to `mempool` to reflect our own types as this is not a standard endpoint and names differ between implementations.  **Description** * Add `Mempool::content` method which returns all transactions * Add `mempool_content` rpc endpoint which returns all mempool transactions grouped by sender and indexed by nonce * (Misc) `RpcTransaction::build` now supports optional transaction index & block number   Closes #2864

**Motivation** Reduce coupling between crates ethrex_storage and ethrex_vm  **Description** - Move `account_update.rs` from `storage` to `common/types` - Fix imports   Closes #2852

…cks in batch (#2890) **Motivation** - We don't want to implement anything for forks previous than Paris, so this can be deleted. **Description**   Closes #issue_number

**Motivation**  - Add docs about errors in the vm because maybe it isn't completely clear which are propagated and which are not. **Description**  Note: I was thinking that maybe we should be more clear with our errors struct. Maybe we should have a struct `LEVMError` that has inside 4 types of errors: `Internal`, `Database`, `TxValidation`, `EVM`. That way it's easier to understand I think. (We should also do some clearing up because it's quite messy and sometimes we don't even use the appropriate errors I've seen)  Closes #1537 I opened [this issue](#2886) for refactoring errors because they are quite messy

…ool (#2906) **Motivation** Following the `rev_comparison` levm bench tool's README to run the tool results in an error as the solidity compiler is not installed. This is not mentioned as a dependency, so this PR updates the README to mention that solidity compiler is required to use the tool and how to install it.  **Description** * Mention solidity compiler dependency + how to install it on levm's `rev_comparison` benchmark tool README   Closes #issue_number

…#2871) **Motivation**  **Description** - Update blockchain tests from 4.3.0 to 4.5.0 - Update state tests from pectra-devnet-6 to 4.5.0 - Remove tests from old forks (Constantinople folder)  Closes #issue_number

**Motivation** Run the hiveview as default when running hive tests for a better visualization **Description** New makefile target that builds and executes the hiveview with the logs created when running hive tests

**Motivation** Adds an RPC method that allows reading all transactions currently in the mempool. This endpoint was based off of Geth's `txpool_content` endpoint ([doc](https://geth.ethereum.org/docs/interacting-with-geth/rpc/ns-txpool#txpool-content)) and follows the same response logic & format. As we have no notion of `queued` mempool transactions currenlty, this field will be permanently left empty The namescape and endpoint currently uses `txpool` instead of `mempool` for immediate compatibility with components compatible with geth, we should consider changing the name back to `mempool` to reflect our own types as this is not a standard endpoint and names differ between implementations.  **Description** * Add `Mempool::content` method which returns all transactions * Add `mempool_content` rpc endpoint which returns all mempool transactions grouped by sender and indexed by nonce * (Misc) `RpcTransaction::build` now supports optional transaction index & block number   Closes #2864

**Motivation** Reduce coupling between crates ethrex_storage and ethrex_vm  **Description** - Move `account_update.rs` from `storage` to `common/types` - Fix imports   Closes #2852

**Motivation**  The protocol capability offset was hardcoded within the msg code. **Description** In order to decouple the msg code from the protocol offset, a const was created with the len of the protocol.   [geth reference](https://github.com/ethereum/go-ethereum/blob/20ad4f500e7fafab93f6d94fa171a5c0309de6ce/cmd/devp2p/internal/ethtest/protocol.go#L62) Closes #2902

**Motivation** When running `make run-hive SIMULATION=...` and any of the tests failed, the hiveview would not open and we could not visualize the tests on the browser **Description** The error is ignored when running the hive simulation so the hiveview can be built and executed.

**Motivation** Add specific error variants for system contract errors `SystemContractEmpty` & `SystemContractCallFailed`.  **Description** * Add error variants `SystemContractEmpty` & `SystemContractCallFailed` * (Misc) minor change to error message   Allows us to better map errors on execution-spec-tests

**Motivation** - Fix holesky Prague syncing with LEVM **Description** - I previously misunderstood the behavior between [EIP 7702](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-7702.md) and precompiles and because of that some edge cases were breaking our VM. The current solution I believe is implemented correctly and is also simpler than what I thought. Before we were luckily (unluckily I'd say) passing all EFTests despite this misimplementation.  Closes #issue_number

**Motivation** *Depends on #2679* The `eth` pair was not implemented in the current node record struct. Using this information allow us to discard incompatible nodes faster when trying to connect to a new peer **Description** The fork_id struct is updated every time a ENRresquest/ENRresponse msg is being received. The `eth` pair contains a single element list, which is a ForkId element. It's encoded/decoded using the default RLP procedure. The P2P TCP connections starts only when the ENR is validated. The logic of this was changed, before when a pong was received (after our ping) a new TCP connection was established. Now, the ENR pairs have to be validated in order to start a new TCP connection. When exchanging the ENRrequest/ENRresponse messages the `eth` pair is now included It can be tested starting a new node with debug level: ``` cargo run --bin ethrex -- --network test_data/genesis-kurtosis.json --log.level=debug ``` And connecting a new peer using the following command: ``` cargo run --bin ethrex -- \ --network ./test_data/genesis-kurtosis.json \ --bootnodes=$(curl -s http://localhost:8545 \ -X POST \ -H "Content-Type: application/json" \ --data '{"jsonrpc":"2.0","method":"admin_nodeInfo","params":[],"id":1}' \ | jq -r '.result.enode') \ --datadir=ethrex_c \ --authrpc.port=8553 \ --http.port=8547 \ --p2p.port=30388 \ --discovery.port=30310 ``` A debug msg can be seen once the `eth` pair is validated Also a new test has been done to test this new validation adding a node with a correct forkId and a node with an invalid forkId. For running the tests, it was needed to initialize the db so the forkId struct could be built from those values. [ETH enr entry](https://github.com/ethereum/devp2p/blob/master/enr-entries/eth.md) [EIP-2124](https://eips.ethereum.org/EIPS/eip-2124) [Ethrex Docs](https://github.com/lambdaclass/ethrex/blob/main/crates/networking/docs/Network.md)   Closes #1799

**Motivation**  We need an automated way to make releases for the L2. **Description**  Added a new Github workflow that cross-compiles the L2 components and makes a new release with the binaries. To trigger the workflow, a tag with name `l2_vX.Y.Z` has to be created. A changelog will be auto-generated based on the last tag before this one. Binaries are compiled for linux (x86-64 & arm64) and macos (arm64)

**Motivation**  **Description**   Closes #issue_number

**Motivation**  `Ownable2Step` is safer than `Ownable`, as it requires the new owner to accept the ownership transfer. **Description**   --------- Co-authored-by: ilitteri <[email protected]>

…ng) (#2687) **Motivation**  Refactor the Patricia Merkle Trie to avoid rehashing the affected part of the trie every time it is modified. Delay hashing until its hash is required.  Replaces node hash references by either a `NodeHash` as before (for unbuffered nodes) or a node itself (for modified nodes).  Closes #issue_number

**Motivation** Ethrex is composed of several smaller projects and each of them uses a different library for secp256k1 cryptography. This is not a problem right now because the usage of some of these libraries is gated by feature flags (i.e. `l2` flag). But if we aim to reduce the amount of feature flags used across the project we will need to use a single lib to avoid future errors and name clashes. **Description** This PR removes the `libsecp256k1` crate from the workspace, in favour of the one required by `SP1` (the patched `secp25k1` crate).  Closes #issue_number --------- Co-authored-by: Manuel Iñaki Bilbao <[email protected]>

**Motivation** This aims to solve the case where a null gas tip is returned by `eth_maxPriorityFeePerGas` endpoint when the blocks used for tip estimation are empty (aka don't have transactions to obtain the tip from). Looking at Geth's implementation, I saw that for these cases [the previously calculated gas tip is used in place of the empty block's transactions' tip](https://github.com/ethereum/go-ethereum/blob/368e16f39d6c7e5cce72a92ec289adbfbaed4854/eth/gasprice/gasprice.go#L195). This PR aims to implement this logic by keeping track of the last estimated gas tip and using it in the case where gas tips are collected from the queried blocks. It also keeps track of the latest hash for which we estimated the tip so we don't need to estimate more than once for a given block.  **Description** * Add `GasEstimator` in place of the standalone `estimate_gas_tip` so we can save and use data from previous estimations when estimating gas tips * `estimate_gas_tip` no longer returns an `Option` * Avoid estimating gas tips more than once for a single latest block * Use previously estimated gas tip when we cannot obtain gas tip values from the latest blocks (aka all queried blocks are empty of transactions)   **Comments** The diff of `estimate_gas_tip` is not visible due to it being moved inside the impl block and its file being renamed, but the main logic was left unchanged, the only changes are at the top (using precomputed value if the tip was already estimated for that block) and at the bottom (using the previously computed value if no tips can be obtained + saving current values) Closes #2682

**Motivation**  - The goal is to return an error if there's a problem when accessing the database instead of panicking. **Description**   Co-authored-by: Lucas Fiegl <[email protected]>

MegaRedHand and others added 10 commits July 1, 2024 13:03

feat: compute transactions root for a block

a685ff2

fix: was encoding LegacyTransaction incorrectly

611bc86

fix: RLP encode index

49f0374

Merge branch 'main' into compute-transactions-root

7080893

Merge branch 'main' into compute-transactions-root

5f9e6eb

refactor: add Transaction::encode_with_type

a81897f

refactor: add TxType enum for encoding tx type

b966cf4

refactor: add TxKind struct

2c59b6d

Merge branch 'main' into compute-transactions-root

830ecac

add receipts root computation

67f1db0

ricomateo added 4 commits July 2, 2024 17:07

fix: the receipt trie value was being computed wrong

3f2dac6

the value must be rlp(receipt) instead of tx_type || rlp(receipt) (if tx_type != 0)

fix: compute receipts trie value correctly

8e23699

the previous way in which the receipts trie values were computed was the right way

remove unnecessary constructor

3b32d29

merge main

ff376e1

ricomateo marked this pull request as ready for review July 2, 2024 20:59

ricomateo requested a review from a team as a code owner July 2, 2024 20:59

MegaRedHand reviewed Jul 2, 2024

View reviewed changes

crates/core/src/types/block.rs Outdated Show resolved Hide resolved

fix: move compute_receipts_root out of BlockBody impl

f02abf1

MegaRedHand approved these changes Jul 3, 2024

View reviewed changes

MegaRedHand merged commit b3a16bf into main Jul 3, 2024
3 checks passed

MegaRedHand deleted the compute-receipts-root branch July 3, 2024 13:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: compute receipts root #111

feat: compute receipts root #111

Uh oh!

ricomateo commented Jul 2, 2024

Uh oh!

Uh oh!

MegaRedHand left a comment

Uh oh!

Uh oh!

Uh oh!

feat: compute receipts root #111

feat: compute receipts root #111

Uh oh!

Conversation

ricomateo commented Jul 2, 2024

Uh oh!

Uh oh!

MegaRedHand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!