fix(l1): add deposit request layout validations + return invalid deposit request error #2832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
fmoletta
changed the title
mpaulucci
reviewed
May 19, 2025
| @@ -17,6 +20,11 @@ const DEPOSIT_TYPE: u8 = 0x00; | |||
| const WITHDRAWAL_TYPE: u8 = 0x01; | |||
| const CONSOLIDATION_TYPE: u8 = 0x02; | |||
|
|
|||
| lazy_static! { | |||
| static ref DEPOSIT_TOPIC: H256 = | |||
| H256::from_str("649bbc62d0e31342afea4e5cd82d4049e7e1ee912fc0889aa790803be39038c5").unwrap(); | |||
There was a problem hiding this comment.
Do we want to have these constants in a centralized place like https://github.com/lambdaclass/ethrex/blob/main/crates/common/constants.rs ?
There was a problem hiding this comment.
It is something specific to requests so I don't think we will be using it anywhere else to warrant it being centralized
mpaulucci
approved these changes
May 19, 2025
JereSalo
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when we fail to parse a deposit request we simply ignore it and keep the rest of the deposits, relying on the request hash check afterwards to notice the missing deposit request. This PR handles the error earlier and returns the appropriate
InvalidDepositRequest Error. This will provide better debugging information and also more accurate testing via tools such asexecution-spec-testswhich rely on specific error returns.We also were not correctly validating the layout according to the EIP, as we were only checking the total size and not the size and offset of each request field
Description
Allows us to address review comment made on execution-specs-test PR ethereum/execution-spec-tests#1607 + also closes #2132