-
Notifications
You must be signed in to change notification settings - Fork 141
feat: add support for ethrex client #1607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @fmoletta, thanks for implementing this :) The CI error is basically a linting issue, it will most likely go away if you run the following command with the new file as parameter: uv run ruff check --fix ... Also, lines with more than a 100 characters will make the lint check fail, and these might sometimes not be fixed with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I left a few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
β¦sit request error (#2832) **Motivation** Currently, when we fail to parse a deposit request we simply ignore it and keep the rest of the deposits, relying on the request hash check afterwards to notice the missing deposit request. This PR handles the error earlier and returns the appropriate `InvalidDepositRequest Error`. This will provide better debugging information and also more accurate testing via tools such as `execution-spec-tests` which rely on specific error returns. We also were not correctly validating the layout according to the [EIP](https://eips.ethereum.org/EIPS/eip-6110), as we were only checking the total size and not the size and offset of each request field <!-- Why does this pull request exist? What are its goals? --> **Description** * Check that the full layout of deposit requests is valid (aka the internal sizes and offsets of the encoded data) * Handle errors when parsing deposit requests * Check log topic matches deposit topic before parsing a request as a deposit request <!-- A clear and concise general description of the changes this PR introduces --> <!-- Link to issues: Resolves #111, Resolves #222 --> Allows us to address review comment made on execution-specs-test PR ethereum/execution-spec-tests#1607 + also closes #2132
ποΈ Description
Adds exception mapping for ethrex errors on consume tests
π Related Issues
β Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.