Skip to content

feat: add support for ethrex client #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 19, 2025
Merged

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented May 15, 2025

πŸ—’οΈ Description

Adds exception mapping for ethrex errors on consume tests

πŸ”— Related Issues

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.

@marioevz
Copy link
Member

Hi @fmoletta, thanks for implementing this :)

The CI error is basically a linting issue, it will most likely go away if you run the following command with the new file as parameter:

uv run ruff check --fix ...

Also, lines with more than a 100 characters will make the lint check fail, and these might sometimes not be fixed with ruff automatically.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I left a few comments.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit 9374ffc into ethereum:main May 19, 2025
11 checks passed
github-merge-queue bot pushed a commit to lambdaclass/ethrex that referenced this pull request May 19, 2025
…sit request error (#2832)

**Motivation**
Currently, when we fail to parse a deposit request we simply ignore it
and keep the rest of the deposits, relying on the request hash check
afterwards to notice the missing deposit request. This PR handles the
error earlier and returns the appropriate `InvalidDepositRequest Error`.
This will provide better debugging information and also more accurate
testing via tools such as `execution-spec-tests` which rely on specific
error returns.
We also were not correctly validating the layout according to the
[EIP](https://eips.ethereum.org/EIPS/eip-6110), as we were only checking
the total size and not the size and offset of each request field
<!-- Why does this pull request exist? What are its goals? -->

**Description**
* Check that the full layout of deposit requests is valid (aka the
internal sizes and offsets of the encoded data)
* Handle errors when parsing deposit requests
* Check log topic matches deposit topic before parsing a request as a
deposit request
<!-- A clear and concise general description of the changes this PR
introduces -->

<!-- Link to issues: Resolves #111, Resolves #222 -->

Allows us to address review comment made on execution-specs-test PR
ethereum/execution-spec-tests#1607 + also closes
#2132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants