Release for a private repository

[Lansoweb]

Bug Report

I've been using automatic-releses for my open-source projects for some time, but yesterday I tried on a private repository and I'm getting a 422 error during fetchMilestoneIssues.

Q	A
Version(s)	<=1.12.0

Summary

If I try to release to a private repository, the fetchMilestoneIssues within the jwage/changelog-generator fails with a 422 error because it does not have the github credentials.

I tested on 1.11.1 and 1.12.0. I'm opening a PR for a fix in a few minutes.

Current behavior

In IssueClient.php line 56:
  [RuntimeException]
  API call to GitHub failed with status code 422 and message "Validation Failed"

Exception trace:
  at /app/vendor/jwage/changelog-generator/src/ChangelogGenerator/IssueClient.php:56
 ChangelogGenerator\IssueClient->execute() at /app/vendor/jwage/changelog-generator/src/ChangelogGenerator/IssueFetcher.php:32
 ChangelogGenerator\IssueFetcher->fetchMilestoneIssues() at /app/vendor/jwage/changelog-generator/src/ChangelogGenerator/IssueRepository.php:24
 ChangelogGenerator\IssueRepository->getMilestoneIssues() at /app/vendor/jwage/changelog-generator/src/ChangelogGenerator/ChangelogGenerator.php:36
 ChangelogGenerator\ChangelogGenerator->generate() at /app/src/Github/JwageGenerateChangelog.php:54
 Laminas\AutomaticReleases\Github\JwageGenerateChangelog->__invoke() at /app/src/Github/CreateReleaseTextThroughChangelog.php:50
 Laminas\AutomaticReleases\Github\CreateReleaseTextThroughChangelog->__invoke() at /app/src/Github/MergeMultipleReleaseNotes.php:39
 Laminas\AutomaticReleases\Github\MergeMultipleReleaseNotes::Laminas\AutomaticReleases\Github\{closure}() at /app/vendor/azjezz/psl/src/Psl/Vec/map.php:38
 Psl\Vec\{closure}() at n/a:n/a
 array_map() at /app/vendor/azjezz/psl/src/Psl/Vec/map.php:39
 Psl\Vec\map() at /app/src/Github/MergeMultipleReleaseNotes.php:40
 Laminas\AutomaticReleases\Github\MergeMultipleReleaseNotes->__invoke() at /app/src/Application/Command/ReleaseCommand.php:86
 Laminas\AutomaticReleases\Application\Command\ReleaseCommand->execute() at /app/vendor/symfony/console/Command/Command.php:256
 Symfony\Component\Console\Command\Command->run() at /app/vendor/symfony/console/Application.php:971
 Symfony\Component\Console\Application->doRunCommand() at /app/vendor/symfony/console/Application.php:290
 Symfony\Component\Console\Application->doRun() at /app/vendor/symfony/console/Application.php:166
 Symfony\Component\Console\Application->run() at /app/bin/console.php:169
 Laminas\AutomaticReleases\WebApplication\{closure}() at /app/bin/console.php:170

laminas:automatic-releases:release

How to reproduce

Install the action on a private repository.

Expected behavior

Release done successfully.

[Ocramius]

A 422 seems to indicate a completely different issue there: potentially a bug in `jwage/changelog-generator` 🤔

…

On Sat, May 22, 2021, 11:33 Leandro Silva ***@***.***> wrote: Bug Report I've been using automatic-releses for my open-source projects for some time, but yesterday I tried on a private repository and I'm getting a 422 error during fetchMilestoneIssues. Q A Version(s) <=1.12.0 Summary If I try to release to a private repository, the fetchMilestoneIssues within the jwage/changelog-generator fails with a 422 error because it does not have the github credentials. I tested on 1.11.1 and 1.12.0. I'm opening a PR for a fix in a few minutes. Current behavior In IssueClient.php line 56: [RuntimeException] API call to GitHub failed with status code 422 and message "Validation Failed" Exception trace: at /app/vendor/jwage/changelog-generator/src/ChangelogGenerator/IssueClient.php:56 ChangelogGenerator\IssueClient->execute() at /app/vendor/jwage/changelog-generator/src/ChangelogGenerator/IssueFetcher.php:32 ChangelogGenerator\IssueFetcher->fetchMilestoneIssues() at /app/vendor/jwage/changelog-generator/src/ChangelogGenerator/IssueRepository.php:24 ChangelogGenerator\IssueRepository->getMilestoneIssues() at /app/vendor/jwage/changelog-generator/src/ChangelogGenerator/ChangelogGenerator.php:36 ChangelogGenerator\ChangelogGenerator->generate() at /app/src/Github/JwageGenerateChangelog.php:54 Laminas\AutomaticReleases\Github\JwageGenerateChangelog->__invoke() at /app/src/Github/CreateReleaseTextThroughChangelog.php:50 Laminas\AutomaticReleases\Github\CreateReleaseTextThroughChangelog->__invoke() at /app/src/Github/MergeMultipleReleaseNotes.php:39 Laminas\AutomaticReleases\Github\MergeMultipleReleaseNotes::Laminas\AutomaticReleases\Github\{closure}() at /app/vendor/azjezz/psl/src/Psl/Vec/map.php:38 Psl\Vec\{closure}() at n/a:n/a array_map() at /app/vendor/azjezz/psl/src/Psl/Vec/map.php:39 Psl\Vec\map() at /app/src/Github/MergeMultipleReleaseNotes.php:40 Laminas\AutomaticReleases\Github\MergeMultipleReleaseNotes->__invoke() at /app/src/Application/Command/ReleaseCommand.php:86 Laminas\AutomaticReleases\Application\Command\ReleaseCommand->execute() at /app/vendor/symfony/console/Command/Command.php:256 Symfony\Component\Console\Command\Command->run() at /app/vendor/symfony/console/Application.php:971 Symfony\Component\Console\Application->doRunCommand() at /app/vendor/symfony/console/Application.php:290 Symfony\Component\Console\Application->doRun() at /app/vendor/symfony/console/Application.php:166 Symfony\Component\Console\Application->run() at /app/bin/console.php:169 Laminas\AutomaticReleases\WebApplication\{closure}() at /app/bin/console.php:170 laminas:automatic-releases:release How to reproduce Install the action on a private repository. Expected behavior Release done successfully. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#139>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABFVECVO2M553I6COHCM33TO527RANCNFSM45KO6DHQ> .

[Lansoweb]

Yes, the code tries to use the github token here but the this project does not provide it. Just adding the token solved the problem. Just opened the PR with the change.

[Ocramius]

Handled in #140