Skip to content

CreateMilestones command is not covered by any tests #147

@Ocramius

Description

@Ocramius
Q A
Version(s) 1.12.0

Summary

This code does not seem to be touched/verified by any existing tests:

final class CreateMilestones extends Command
{
private LoadCurrentGithubEvent $loadEvent;
private CreateMilestone $createMilestone;
public function __construct(
LoadCurrentGithubEvent $loadEvent,
CreateMilestone $createMilestone
) {
parent::__construct('laminas:automatic-releases:create-milestones');
$this->loadEvent = $loadEvent;
$this->createMilestone = $createMilestone;
}
public function execute(InputInterface $input, OutputInterface $output): int
{
$milestoneClosedEvent = ($this->loadEvent)();
$repositoryName = $milestoneClosedEvent->repository();
$releaseVersion = $milestoneClosedEvent->version();
$this->createMilestoneIfNotExists($repositoryName, $releaseVersion->nextPatch());
$this->createMilestoneIfNotExists($repositoryName, $releaseVersion->nextMinor());
$this->createMilestoneIfNotExists($repositoryName, $releaseVersion->nextMajor());
return 0;
}
private function createMilestoneIfNotExists(RepositoryName $repositoryName, SemVerVersion $version): void
{
try {
($this->createMilestone)($repositoryName, $version);
} catch (CreateMilestoneFailed) {
return;
}
}
}

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions