Skip to content

README: Do not add all possible workflows #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2021
Merged

README: Do not add all possible workflows #103

merged 1 commit into from
Jan 25, 2021

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Jan 24, 2021

Q A
Documentation yes
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

Seems to me the workflows in examples are exclusive, they are alternatives and should pick only one.

@glensc
Copy link
Contributor Author

glensc commented Jan 25, 2021

If the change is valid, maybe it's easier to put the different flows to different sub-directories:

➔ tree examples/
examples/
├── release-on-milestone-closed
│   └── release-on-milestone-closed.yml
└── release-on-milestone-closed-triggering-release-event
    └── release-on-milestone-closed-triggering-release-event.yml

2 directories, 2 files

Ocramius
Ocramius reviewed Jan 25, 2021
View reviewed changes
@glensc glensc marked this pull request as ready for review January 25, 2021 14:45
@Ocramius Ocramius added this to the 1.9.2 milestone Jan 25, 2021
@Ocramius Ocramius self-assigned this Jan 25, 2021
@Ocramius Ocramius merged commit eaca30f into laminas:1.9.x Jan 25, 2021
@Ocramius
Copy link
Member

Thanks @glensc

@glensc glensc deleted the patch-4 branch January 25, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Documentation Enhancement
Projects
None yet
Milestone
1.9.2
Development

Successfully merging this pull request may close these issues.
2 participants
@glensc @Ocramius