Skip to content

Fix workflow trigger to include all branches and tags #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

core23
Copy link
Contributor

@core23 core23 commented Feb 8, 2021

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

Fixes the CI build triggers:

  • Use versioned branches (e.g. 1.9.x) instead of master
  • Run CI on branch and tag creation. The CI for the current 1.9.x branch did never run.

pull_request:
push:
branches:
- "master"
- "*.x"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop any filter on branches: overall (can leave it empty and it should pick up everything)

Signed-off-by: core23 <[email protected]>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ocramius Ocramius added this to the 1.9.2 milestone Feb 9, 2021
@Ocramius Ocramius self-assigned this Feb 9, 2021
@Ocramius Ocramius merged commit 32f970e into laminas:1.9.x Feb 9, 2021
@Ocramius Ocramius changed the title Fix workflow trigger Fix workflow trigger to include all branches and tags Feb 9, 2021
@core23 core23 deleted the fix-ci-trigger branch February 9, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants