Skip to content

chore(dependencies): upgrade PSL to 1.8.1 #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2021

Conversation

azjezz
Copy link
Contributor

@azjezz azjezz commented Oct 3, 2021

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA no

Description

upgrade PSL to 1.8, which now includes both STDOUT and STDERR content in the exception message for fail Shell\execute calls.

closes #166

@azjezz
Copy link
Contributor Author

azjezz commented Oct 3, 2021

cc @greg0ire

@greg0ire
Copy link

greg0ire commented Oct 3, 2021

Let me reopen the issue, it makes more sense now there is a fix :)

@Ocramius Ocramius added dependencies Pull requests that update a dependency file Enhancement labels Oct 3, 2021
@Ocramius Ocramius added this to the 1.13.0 milestone Oct 3, 2021
@Ocramius Ocramius self-assigned this Oct 3, 2021
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@Ocramius Ocramius merged commit 47e58f8 into laminas:1.13.x Oct 3, 2021
@Ocramius
Copy link
Member

Ocramius commented Oct 3, 2021

Thanks @azjezz and @greg0ire!

@azjezz azjezz deleted the chore/upgrade-psl branch October 3, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display command output on failure
3 participants