Skip to content

Check the response code is >= 200 && <= 299 on release #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Check the response code is >= 200 && <= 299 on release #204

merged 2 commits into from
Aug 17, 2022

Conversation

internalsystemerror
Copy link
Member

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

I don't see an issue for it, but the response code check is an OR when it should be an AND.

@Ocramius Ocramius added this to the 1.15.0 milestone Aug 17, 2022
@Ocramius Ocramius self-assigned this Aug 17, 2022
@Ocramius Ocramius added the Bug Something isn't working label Aug 17, 2022
@Ocramius Ocramius changed the base branch from 1.15.x to 1.14.x August 17, 2022 17:40
@Ocramius Ocramius changed the base branch from 1.14.x to 1.15.x August 17, 2022 17:40
@Ocramius Ocramius merged commit d90f604 into laminas:1.15.x Aug 17, 2022
@internalsystemerror internalsystemerror deleted the hotfix/incorrect-release-api-operand branch August 18, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants