Provide the ability to log to STDERR #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds psr/log and monolog/monolog as dependencies. Additionally, sets up the environment and application to allow consuming a log. The new `LOG_LEVEL` environment variable is optional, and will default to `'INFO'`. In the `bin/console.php` file, we now create a Monolog logger instance with a `StreamHandler` that writes to the `STDERR` stream, using the configured `LOG_LEVEL`. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
This patch accomplishes the following: - It ensures that the handling of env variables with default values is consistent with the type hints. - It adds a constructor dependency on the psr/log `LoggerInterface` to `ReleaseChangelogViaKeepAChangelog`. - It adds logging statements at key workflow points in that class, using the provided logger. - It updates the `bin/console.php` script to provide the logger instance to the `ReleaseChangelogViaKeepAChangelog` instance. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Ocramius
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch accomplishes the following:
LOG_LEVELenv variable, defaulting to'INFO'.bin/console.phpto create a monologLoggerinstance that composes aStreamHandlertied to theSTDERRresource, and logging at the providedLOG_LEVEL.ReleaseChangelogViaKeepAChangelogclass to compose a psr/logLoggerInterface, and use it to log informative messages during its workflow.bin/console.phpscript to inject theReleaseChangelogViaKeepAChangeloginstance with the configuredLoggerinstance.We likely will want even more logging; I've just provided the barebones of what we need, and an example of how to accomplish it.
Fixes #14