Do not checkout the branch passed to CommitFileViaConsole
#41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
added a commit
to weierophinney/automatic-releases
that referenced
this pull request
Aug 12, 2020
We need to assume we're on the correct branch; otherwise, a checkout operation will lead to an error, aborting the operation. Instead, I've added functionality to verify that we are on the branch provided; if not, an exception is raised. The changes also required annotating that the repository directory, filename, and commit message arguments could not be empty, which required changes elsewhere to ensure this is true before calling on `CommitFile`. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
weierophinney
force-pushed
the
hotfix/do-not-checkout-to-commit
branch
from
fc96c12 to
55057b9
Compare
Ocramius
requested changes
Aug 12, 2020
src/Changelog/BumpAndCommitChangelogVersionViaKeepAChangelog.php
Outdated
Show resolved
Hide resolved
…ve a string Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Renamed `assertBranch` to `assertWeAreOnBranch`. Additionally, instead of: - Process:run - Process:isSuccessful - throw use just `Process::mustRun()` Signed-off-by: Matthew Weier O'Phinney <[email protected]>
|
Feedback incorporated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to assume we're on the correct branch; otherwise, a checkout operation will lead to an error, aborting the operation.
Instead, I've added functionality to verify that we are on the branch provided; if not, an exception is raised.
The changes also required annotating that the repository directory, filename, and commit message arguments could not be empty, which required changes elsewhere to ensure this is true before calling on
CommitFile.