Merge release 1.2.2 into 1.3.x #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Updates the CHANGELOG.md file to add a changelog entry for a new 1.2.1 version.
Updates the CHANGELOG.md file to add a changelog entry for a new 1.2.2 version.
…nch prior to doing work
We should test for the CHANGELOG.md file in the release branch in an
idempotent way; we can use the exit code of `git show
{REF}:CHANGELOG.md` for this.
When we want to change the changelog file, we need to switch to the
associated release branch first.
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Updates `CreateReleaseTextViaKeepAChangelog` to use `git show
{ref}:CHANGELOG.md` to to test for the existence of the file, as well as
to fetch its contents, making the operation idempotent.
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
I was reproducing the same code a ton; time to extract it. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
…elog file on a branch Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Prevents env issues during CI. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Details fix for changelog operations. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
weierophinney
force-pushed
the
1.2.x-merge-up-into-1.3.x_5f3453859c4ec1.80057584
branch
from
a048deb to
d8cf559
Compare
weierophinney
deleted the
1.2.x-merge-up-into-1.3.x_5f3453859c4ec1.80057584
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 1.2.2
1.2.2
Bug,Review Needed