Skip to content

docs: add note about how GITHUB_TOKEN is created #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2020
Merged

docs: add note about how GITHUB_TOKEN is created #71

merged 2 commits into from
Sep 5, 2020

Conversation

ramsey
Copy link
Contributor

@ramsey ramsey commented Sep 5, 2020

Q A
Documentation yes
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

This PR updates the README to include a note about the GIT_TOKEN shown in the examples, with a link to more information about how this environment variable is injected when using GitHub Actions.

Also included is a small change to convert the use of deprecated array dereferencing syntax to the updated, acceptable syntax.

@Ocramius Ocramius self-assigned this Sep 5, 2020
@Ocramius Ocramius added this to the 1.7.0 milestone Sep 5, 2020
@Ocramius Ocramius merged commit e1f8dcc into laminas:1.7.x Sep 5, 2020
@Ocramius
Copy link
Member

Ocramius commented Sep 5, 2020

Thanks @ramsey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants